You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/11/01 11:29:56 UTC
[GitHub] [ozone] adoroszlai commented on pull request #3889: HDDS-7416. Unify license headers for hdds-annotation-processing
adoroszlai commented on PR #3889:
URL: https://github.com/apache/ozone/pull/3889#issuecomment-1298384539
@myskov I agree that having license header in javadoc comment is a bug and should be fixed. I think we can enforce it using `InvalidJavadocPosition` rule.
While would also be nice to have uniform license header, I'm concerned it would cause more problems (conflicts in open PRs, during feature branch merge and future bugfix backports) than the minimal benefits it would bring.
So I suggest dropping the formatting changes and the proposed uniform header from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org