You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "spetz (via GitHub)" <gi...@apache.org> on 2026/04/21 09:50:41 UTC

[PR] fix(bench): anchor hero display to showcase pick, fix gitref links [iggy]

spetz opened a new pull request, #3147:
URL: https://github.com/apache/iggy/pull/3147

   Hero headline read hardware from stale context and name from
   the sweep's peak-throughput benchmark, so displayed fields
   often didn't match the tail chart or "View details" target.
   
   Route all hero headline fields through a single
   `showcase_display` helper sourced from the same pick that
   drives the chart and detail link. Gitref URL now prefixes
   `server-` only for parseable semver tags; raw commits link
   unmodified (iggy releases tag as `server-X.Y.Z`, commits do
   not).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(bench): anchor hero display to showcase pick, fix gitref links [iggy]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3147:
URL: https://github.com/apache/iggy/pull/3147#issuecomment-4287598278

   ## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3147?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 19.35%. Comparing base ([`832c341`](https://app.codecov.io/gh/apache/iggy/commit/832c34164f995dcb5d622213869c5a5e2527e296?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`49918aa`](https://app.codecov.io/gh/apache/iggy/commit/49918aaa7d39936965de3298de254544a881c80a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3147       +/-   ##
   =============================================
   - Coverage     73.25%   19.35%   -53.91%     
     Complexity      943      943               
   =============================================
     Files          1126     1124        -2     
     Lines         98435    87640    -10795     
     Branches      75609    64814    -10795     
   =============================================
   - Hits          72108    16962    -55146     
   - Misses        23720    70286    +46566     
   + Partials       2607      392     -2215     
   ```
   
   | [Components](https://app.codecov.io/gh/apache/iggy/pull/3147/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3147/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.35% <ø> (-73.78%)` | :arrow_down: |
   | [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3147/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.30% <ø> (ø)` | |
   | [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3147/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.40% <ø> (ø)` | |
   | [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3147/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.43% <ø> (ø)` | |
   | [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3147/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.44% <ø> (ø)` | |
   | [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3147/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.41% <ø> (ø)` | |
   [see 623 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3147/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(bench): anchor hero display to showcase pick, fix gitref links [iggy]

Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz merged PR #3147:
URL: https://github.com/apache/iggy/pull/3147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org