You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/07 18:25:06 UTC

[GitHub] [kafka] hachikuji opened a new pull request #9709: MINOR: Configure reconnect backoff in `BrokerToControllerChannelManager`

hachikuji opened a new pull request #9709:
URL: https://github.com/apache/kafka/pull/9709


   We should configure a reconnect backoff for controller connections to prevent tight reconnect loops when the controller cannot be reached. I have borrowed the same configuration we use in `TransactionMarkerChannelManager`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] chia7712 commented on pull request #9709: MINOR: Configure reconnect backoff in `BrokerToControllerChannelManager`

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9709:
URL: https://github.com/apache/kafka/pull/9709#issuecomment-740463736


   ```kafka.api.TransactionsTest.testBumpTransactionalEpoch``` is traced by #9291 - ping for reviews BTW :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] hachikuji commented on pull request #9709: MINOR: Configure reconnect backoff in `BrokerToControllerChannelManager`

Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #9709:
URL: https://github.com/apache/kafka/pull/9709#issuecomment-740775813


   @mumrah Yeah, I noticed that too. I think `ControllerChannelManager` uses more of a synchronous backoff approach, so I left it as is.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] hachikuji merged pull request #9709: MINOR: Configure reconnect backoff in `BrokerToControllerChannelManager`

Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #9709:
URL: https://github.com/apache/kafka/pull/9709


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org