You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@commons.apache.org by ji...@codehaus.org on 2003/09/04 03:36:10 UTC

[jira] Commented: (JELLY-77) [patch] Update jelly:util replace tag to replace entire strings

The following comment has been added to this issue:

     Author: peter royal
    Created: Wed, 3 Sep 2003 8:35 PM
       Body:
I've fixed the javadocs. I'll apply a patch that does string replacement if you make it work off of new parameter names. ie keeping oldChar and newChar for existing behavior, but using old and new to do string replacement.
---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=JELLY-77


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JELLY-77
    Summary: [patch] Update jelly:util replace tag to replace entire strings
       Type: Improvement

     Status: Unassigned
   Priority: Major

 Time Spent: Unknown
  Remaining: Unknown

    Project: jelly
 Components: 
             tags

   Assignee: 
   Reporter: Paul O'Fallon

    Created: Sun, 24 Aug 2003 2:25 PM
    Updated: Sun, 24 Aug 2003 2:25 PM
Environment: win xp, jdk1.3.1

Description:
The replace tag documentation indicates that it replaces "occurrances of strings", but the code only replaces instances of the first character in the old string with the first character in the new string.  It also does not accept an empty string as the new string.  I have a patch that updates the replace tag to replace whole strings, as well as accept empty strings, available here:
http://home.earthlink.net/~ofallon/patches/jelly-util-diff.txt
it updates both the code and the project.xml file to add a dependency on commons-lang.  All of the existing util tag tests still passed after making this change.

If this change is implemented, it may also make sense to change the attributes "oldChar" and "newChar" to just "old" and "new", but I'll leave decision that up to someone else :-)

Thanks,
Paul


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira