[GitHub] [maven-dependency-analyzer] elharo commented on a diff in pull request #81: Prefer JDK classes to Plexus utils

["elharo (via GitHub)" <gi...@apache.org>]

elharo commented on code in PR #81:
URL: https://github.com/apache/maven-dependency-analyzer/pull/81#discussion_r1141349835


##########
src/main/java/org/apache/maven/shared/dependency/analyzer/ClassFileVisitorUtils.java:
##########
@@ -108,41 +106,30 @@ private static void acceptJar( URL url, ClassFileVisitor visitor )
     private static void acceptDirectory( File directory, ClassFileVisitor visitor )
         throws IOException
     {
-        if ( !directory.isDirectory() )
+    
+        List<Path> classFiles = Files.walk( directory.toPath() )
+            .filter( path -> path.toFile().getName().endsWith( ".class" ) )

Review Comment:
   Six of one, half dozen of another. I looked at that and saw that getFileName returned a Path instead of a String, which seemed wrong to me. But if you prefer I can change this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org