You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by wo...@apache.org on 2007/08/27 13:33:15 UTC
svn commit: r570078 -
/portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java
Author: woonsan
Date: Mon Aug 27 04:33:15 2007
New Revision: 570078
URL: http://svn.apache.org/viewvc?rev=570078&view=rev
Log:
During high load testings, I found that an NPE occurred in the constructor of ServletRequestImpl.
The constructor tries to initialize the static members: mergePortalParametersWithPortletParameters, mergePortalParametersBeforePortletParameters. However it checks only if the first static member is null. This causes an NPE on the second static member in a very high load testing environment.
So, checking should be separated for each static member.
Modified:
portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java
Modified: portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java?rev=570078&r1=570077&r2=570078&view=diff
==============================================================================
--- portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java (original)
+++ portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java Mon Aug 27 04:33:15 2007
@@ -136,6 +136,10 @@
{
mergePortalParametersWithPortletParameters =
new Boolean(Jetspeed.getContext().getConfiguration().getBoolean("merge.portal.parameters.with.portlet.parameters", false));
+ }
+
+ if (mergePortalParametersBeforePortletParameters == null)
+ {
mergePortalParametersBeforePortletParameters =
new Boolean(Jetspeed.getContext().getConfiguration().getBoolean("merge.portal.parameters.before.portlet.parameters", false));
}
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org