You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by gr...@apache.org on 2018/02/01 06:20:41 UTC
[05/12] mesos git commit: Removed unnecesssary validations from
`Master::receive()`.
Removed unnecesssary validations from `Master::receive()`.
`validation::scheduler::call::validate(call)` is called at the top of
`master::receive()`, so it doesn't need to validate the calls again.
Review: https://reviews.apache.org/r/65358/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/0c794bd0
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/0c794bd0
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/0c794bd0
Branch: refs/heads/master
Commit: 0c794bd03fc40fc83d0ad0ac4b866807b95b7321
Parents: bcd7fd8
Author: Gaston Kleiman <ga...@mesosphere.io>
Authored: Wed Jan 31 12:59:29 2018 -0800
Committer: Greg Mann <gr...@gmail.com>
Committed: Wed Jan 31 18:14:23 2018 -0800
----------------------------------------------------------------------
src/master/master.cpp | 13 -------------
1 file changed, 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/0c794bd0/src/master/master.cpp
----------------------------------------------------------------------
diff --git a/src/master/master.cpp b/src/master/master.cpp
index b97ebae..e5ee53a 100644
--- a/src/master/master.cpp
+++ b/src/master/master.cpp
@@ -2414,24 +2414,11 @@ void Master::receive(
break;
case scheduler::Call::ACKNOWLEDGE: {
- Try<id::UUID> uuid = id::UUID::fromBytes(call.acknowledge().uuid());
- if (uuid.isError()) {
- drop(from, call, uuid.error());
- return;
- }
-
acknowledge(framework, call.acknowledge());
break;
}
case scheduler::Call::ACKNOWLEDGE_OPERATION_STATUS: {
- Try<id::UUID> uuid = id::UUID::fromBytes(
- call.acknowledge_operation_status().uuid());
- if (uuid.isError()) {
- drop(from, call, uuid.error());
- return;
- }
-
acknowledgeOperationStatus(
framework,
call.acknowledge_operation_status());