[GitHub] [kafka] ijuma commented on a diff in pull request #13234: KAFKA-14706 Move/rewrite ShutdownableThread to server-common module.

["ijuma (via GitHub)" <gi...@apache.org>]

ijuma commented on code in PR #13234:
URL: https://github.com/apache/kafka/pull/13234#discussion_r1103848236


##########
examples/src/main/java/kafka/examples/Consumer.java:
##########
@@ -83,13 +83,4 @@ public void doWork() {
         }
     }
 
-    @Override
-    public String name() {

Review Comment:
   Let's file a ticket in JIRA for removing the dependency on `ShutdownableThread` - our examples should not rely on internal apis.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org