[GitHub] [airflow] jedcunningham commented on a diff in pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #24673:
URL: https://github.com/apache/airflow/pull/24673#discussion_r907810626


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -112,7 +112,7 @@ class KubernetesPodOperator(BaseOperator):
     :param annotations: non-identifying metadata you can attach to the Pod.
         Can be a large range of data, and can include characters
         that are not permitted by labels.
-    :param resources: resources for the launched pod.
+    :param k8s_resources: resources for the launched pod.

Review Comment:
   > or what about `pod_resources` -- this seems better
   
   `container_resources` would be better (it is set on the container after all)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org