You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Sherry302 <gi...@git.apache.org> on 2016/07/02 01:50:38 UTC
[GitHub] spark pull request #14024: [SPARK-15923][YARN] Spark Application rest api re...
GitHub user Sherry302 opened a pull request:
https://github.com/apache/spark/pull/14024
[SPARK-15923][YARN] Spark Application rest api returns 'no such app: …
## What changes were proposed in this pull request?
1. Updated the monitoring.md doc.
2. In YarnSchedulerBackend.scala: make applications run in Yarn cluster mode have attemptID "1" by default.
## How was this patch tested?
Manual tests passed.
…<appId>'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Sherry302/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14024.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14024
----
commit a15dee1aee3afa53a455c4b0aba5e3388a0129d3
Author: Weiqing Yang <ya...@gmail.com>
Date: 2016-07-02T01:45:38Z
[SPARK-15923][YARN] Spark Application rest api returns 'no such app: <appId>'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14024: [SPARK-15923][YARN] Spark Application rest api re...
Posted by Sherry302 <gi...@git.apache.org>.
Github user Sherry302 closed the pull request at:
https://github.com/apache/spark/pull/14024
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14024: [SPARK-15923][YARN] Spark Application rest api re...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/14024#discussion_r69458948
--- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala ---
@@ -101,10 +101,10 @@ private[spark] abstract class YarnSchedulerBackend(
* attempts. Applications run in client mode will not have attempt IDs.
* This attempt ID only includes attempt counter, like "1", "2".
*
- * @return The application attempt id, if available.
+ * @return The application attempt id, if not available, will return "1".
*/
override def applicationAttemptId(): Option[String] = {
- attemptId.map(_.getAttemptId.toString)
+ Some(attemptId.map(_.getAttemptId.toString).getOrElse("1"))
--- End diff --
This change will break the assumptions we made before (attemptId is unset for client-mode scheduler).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14024: [SPARK-15923][YARN] Spark Application rest api returns '...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14024
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org