You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/23 09:38:58 UTC
[GitHub] [maven-gh-actions-shared] nielsbasjes opened a new pull request, #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
nielsbasjes opened a new pull request, #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44
https://issues.apache.org/jira/browse/SCM-988
Not all tests for maven-scm can run on all platforms because mercurial (hg) is not installed on macOS in the default `macOS-latest` image provided by Github.
**NOTE: I am unable to test if this change actually works**
CC: @michael-o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1134678162
Please add flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] nielsbasjes commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1134662334
Without the `brew update` (so only the install) it takes only 15-18 seconds extra.
@slawekjaranowski Which solution direction do you prefer?
Just adding it always? Making it a flag as you suggested? Or something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] nielsbasjes commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1135044224
> > > Merged.
> >
> > Ehhh, I still had to make the flag to make it optional.
>
> You mean only for Maven SCM?
No, for this project. So downstream projects can choose yo have hg or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] michael-o closed pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
michael-o closed pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
URL: https://github.com/apache/maven-gh-actions-shared/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] nielsbasjes commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1134560603
> To investigate
>
> * how long take such new task
Yes, valid question.
Perhaps not doing the update (as documented by Github) but just install mercurial?
> * what on other os - linux, windows
The logging of this PR https://github.com/apache/maven-scm/pull/140 shows that on both Linux and Windows have HG installed and it works. On macOS it is not installed and the tests are skipped.
Snippets from the logs:
Ubuntu:
```
2022-05-23T08:00:42.8027031Z [INFO] Running org.apache.maven.scm.provider.hg.command.checkout.HgCheckOutCommandTckTest
2022-05-23T08:00:42.8284666Z [main] INFO org.apache.maven.scm.provider.hg.HgUtils - EXECUTING: /bin/sh -c cd '/home/runner/work/maven-scm/maven-scm/maven-scm-providers/maven-scm-provider-hg/target/test-branch' && 'hg' 'init'
```
Windows
```
2022-05-23T08:02:15.5912662Z [INFO] Running org.apache.maven.scm.provider.hg.command.checkout.HgCheckOutCommandTckTest
2022-05-23T08:02:15.6441394Z [main] INFO org.apache.maven.scm.provider.hg.HgUtils - EXECUTING: cmd.exe /X /C "hg init"
```
macOS
```
2022-05-23T08:00:43.4287380Z [INFO] Running org.apache.maven.scm.provider.hg.command.checkout.HgCheckOutCommandTckTest
2022-05-23T08:00:43.4345300Z [WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.005 s - in org.apache.maven.scm.provider.hg.command.checkout.HgCheckOutCommandTckTest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] michael-o commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1135013361
Stupid question, does this work now with GH Actions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] nielsbasjes commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1135041766
> Merged.
Ehhh, I still had to make the flag to make it optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1134591068
because it is needed only by one project, we can add input parameters, like `with_mercurial` with default value `false`
and execute task conditionally
in scm project we add
```
jobs:
build:
name: Verify
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
with:
with_mercurial: true
```
for testing you can also change workflow in scm PR pointing to your fork
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] michael-o commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1135035064
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] nielsbasjes commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1136520219
> > > > > Merged.
> > > >
> > > >
> > > > Ehhh, I still had to make the flag to make it optional.
> > >
> > >
> > > You mean only for Maven SCM?
> >
> >
> > No, for this project. So downstream projects can choose yo have hg or not.
>
> Just provide a followup PR.
@michael-o @slawekjaranowski
I just did for both this repo and the maven-scm that needs it:
https://github.com/apache/maven-gh-actions-shared/pull/45
https://github.com/apache/maven-scm/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1134682138
to be consistent with format of the other inputs please add something like `with-mercurial` or `instal-mercurial` ... dash as separator 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1135055246
@michael-o this is shared GitHub action used by most of Maven projects 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] nielsbasjes commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1135026380
Yes it does. I updated a branch of maven-scm to use this config and also on macOS all the tests ran successfully with hg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] nielsbasjes commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1134631137
Doing the extra step in CI for macOS takes 41-43 seconds extra.
This includes the `brew update`.
I'm going to experiment some more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] michael-o commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1135042972
> > Merged.
>
> Ehhh, I still had to make the flag to make it optional.
You mean only for Maven SCM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1134441888
To investigate
- how long take such new task
- what on other os - linux, windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1134439548
You can change location of shared action in `maven-verify-test.yml` for testing, and you will see result on your fork.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] nielsbasjes commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1134641034
The test I ran clearly installed mercurial as the related tests were executed successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] michael-o commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1135045378
> > > > Merged.
> > >
> > >
> > > Ehhh, I still had to make the flag to make it optional.
> >
> >
> > You mean only for Maven SCM?
>
> No, for this project. So downstream projects can choose yo have hg or not.
Just provide a followup PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] michael-o commented on pull request #44: [SCM-988] Ensure all images have Git, Svn and Mercurial
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #44:
URL: https://github.com/apache/maven-gh-actions-shared/pull/44#issuecomment-1135059383
> @michael-o this is shared GitHub action used by most of Maven projects 😄
Yes, realized too late. I am lost in the sea of PRs ATM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org