[GitHub] [airflow] rajaths010494 commented on a diff in pull request #27024: Update WasbHook to reflect preference for unprefixed extra

[GitBox <gi...@apache.org>]

rajaths010494 commented on code in PR #27024:
URL: https://github.com/apache/airflow/pull/27024#discussion_r995707276


##########
airflow/providers/microsoft/azure/hooks/wasb.py:
##########
@@ -119,6 +150,17 @@ def __init__(
         except ValueError:
             logger.setLevel(logging.WARNING)
 
+    def _get_field(self, extra_dict, field_name):
+        prefix = 'extra__wasb__'
+        if field_name.startswith('extra_'):
+            raise ValueError(
+                f"Got prefixed name {field_name}; please remove the '{prefix}' prefix "
+                f"when using this method."
+            )
+        if field_name in extra_dict:
+            return extra_dict[field_name] or None

Review Comment:
   Is returning `None` needed to be returned when the key is present in the dict? WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org