You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2023/06/12 10:15:47 UTC
[GitHub] [doris] github-actions[bot] commented on pull request #20716: [Feature](Nereids) Add nereids ut
github-actions[bot] commented on PR #20716:
URL: https://github.com/apache/doris/pull/20716#issuecomment-1587028898
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5242317518") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In minidump/nereids_ut.sh line 41:
IMAGE_PATH=''
^--------^ SC2034 (warning): IMAGE_PATH appears unused. Verify use (or export if used externally).
In minidump/nereids_ut.sh line 47:
RUN_DAEMON=1
^--------^ SC2034 (warning): RUN_DAEMON appears unused. Verify use (or export if used externally).
In minidump/nereids_ut.sh line 55:
HELPER="$2"
^----^ SC2034 (warning): HELPER appears unused. Verify use (or export if used externally).
In minidump/nereids_ut.sh line 59:
IMAGE_TOOL=1
^--------^ SC2034 (warning): IMAGE_TOOL appears unused. Verify use (or export if used externally).
In minidump/nereids_ut.sh line 177:
if [[ -f "${pidfile}" ]]; then
^--------^ SC2154 (warning): pidfile is referenced but not assigned.
In minidump/nereids_ut.sh line 187:
LIMIT=/bin/limit
^---^ SC2034 (warning): LIMIT appears unused. Verify use (or export if used externally).
In minidump/nereids_ut.sh line 195:
if [[ -d "$dir" ]]; then # Check if the path is a directory
^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
if [[ -d "${dir}" ]]; then # Check if the path is a directory
In minidump/nereids_ut.sh line 196:
query_id=$(echo "${dir: -33}")
^-------------------^ SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'.
In minidump/nereids_ut.sh line 198:
"${JAVA}" ${final_java_opt:+${final_java_opt}} -Xmx2g org.apache.doris.nereids.minidump.Minidump $dir ${OPT_VERSION:+${OPT_VERSION}} "$@" > "$temp_file"
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^--------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
"${JAVA}" ${final_java_opt:+${final_java_opt}} -Xmx2g org.apache.doris.nereids.minidump.Minidump "${dir}" ${OPT_VERSION:+${OPT_VERSION}} "$@" > "${temp_file}"
In minidump/nereids_ut.sh line 200:
result=$(cat "$temp_file")
^--------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
result=$(cat "${temp_file}")
In minidump/nereids_ut.sh line 201:
echo "$query_id_head $query_id $sql_head $result" |tee >> "${LOG_DIR}/minidump.out"
^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
echo "${query_id_head} ${query_id} ${sql_head} ${result}" |tee >> "${LOG_DIR}/minidump.out"
For more information:
https://www.shellcheck.net/wiki/SC2034 -- HELPER appears unused. Verify use...
https://www.shellcheck.net/wiki/SC2154 -- pidfile is referenced but not ass...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- minidump/nereids_ut.sh.orig
+++ minidump/nereids_ut.sh
@@ -192,15 +192,13 @@
sql_head="|Sql="
for dir in "${DUMP_FILE_DIR}"/*; do
- if [[ -d "$dir" ]]; then # Check if the path is a directory
- query_id=$(echo "${dir: -33}")
- temp_file=${LOG_DIR}/temp
- "${JAVA}" ${final_java_opt:+${final_java_opt}} -Xmx2g org.apache.doris.nereids.minidump.Minidump $dir ${OPT_VERSION:+${OPT_VERSION}} "$@" > "$temp_file"
+ if [[ -d "$dir" ]]; then # Check if the path is a directory
+ query_id=$(echo "${dir: -33}")
+ temp_file=${LOG_DIR}/temp
+ "${JAVA}" ${final_java_opt:+${final_java_opt}} -Xmx2g org.apache.doris.nereids.minidump.Minidump $dir ${OPT_VERSION:+${OPT_VERSION}} "$@" >"$temp_file"
- result=$(cat "$temp_file")
- echo "$query_id_head $query_id $sql_head $result" |tee >> "${LOG_DIR}/minidump.out"
+ result=$(cat "$temp_file")
+ echo "$query_id_head $query_id $sql_head $result" | tee >>"${LOG_DIR}/minidump.out"
fi
done
-date >> "${LOG_DIR}/minidump.out"
-
-
+date >>"${LOG_DIR}/minidump.out"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org