You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:04:17 UTC
[GitHub] [dolphinscheduler] ruanwenjun opened a new issue #5807: [Improvement][Dao UT] Use h2 in UT
ruanwenjun opened a new issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807
**Describe the question**
Currently, we use database configured at `datasource.properties` in unit test.
This is inconvenient and against the principles of unit test, unit test should run successfully at every environment.
We can use h2 datasource in unit test(https://www.linkedin.com/pulse/unit-testing-using-h2-in-memory-db-raghunandan-gupta).
**Which version of DolphinScheduler:**
-[dev]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] dailidong commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-883288515
> @CalvinKirs can i work on this issue.
hi, do you have any idea about how to implement it? thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] dailidong commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-886397826
@SivaTharun hi guys, any progress? or do you meet any problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] dailidong commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-883589563
BTW, I have tried h2's embedded method some months ago in my local environment and it works, I'm so glad to see you want to implement it, good luck!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SivaTharun commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
SivaTharun commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-888047741
@dailidong i have started working on this issue, and the PR would be ready in a few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SivaTharun commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
SivaTharun commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-883326492
@CalvinKirs @dailidong we can use he embedded in memory database for integration tests, we can follow this [document](https://www.baeldung.com/spring-boot-h2-database), which shows on how to setup h2 database integration.
Also we can construct the tables by including the DDL in `schema.sql` in `src/test/resources` folder.
we can preload the data too , inside the h2 tables, by including the `data.sql` file in `src/test/resources` folder.
This would help us to create, load and drop tables inside h2 database, and this execution will takes place for every integration test as well as mapper/repository test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] dailidong commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-883288515
> @CalvinKirs can i work on this issue.
hi, do you have any idea about how to implement it? thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs closed issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
CalvinKirs closed issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SivaTharun commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
SivaTharun commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-879578578
@CalvinKirs can i work on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-879579672
> @CalvinKirs can i work on this issue.
Of course you are welcome to contribute. You can design first, and then we discuss and start development
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] dailidong commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-883586412
> @CalvinKirs @dailidong we can use he embedded in memory database for integration tests, we can follow this [document](https://www.baeldung.com/spring-boot-h2-database), which shows on how to setup h2 database integration.
>
> Also we can construct the tables by including the DDL in `schema.sql` in `src/test/resources` folder.
> we can preload the data too , inside the h2 tables, by including the `data.sql` file in `src/test/resources` folder.
>
> This would help us to create, load and drop tables inside h2 database, and this execution will takes place for every integration test as well as mapper/repository test.
good job, I have read this document, I think we don't need the spring-boot-starter-data-jpa dependencies, you can have a try, welcome to join Slack workspace through invitation url: https://s.apache.org/dolphinscheduler-slack, and you also can send mail to dev@dolphinscheduler.apache.org if you meet any problem.
I'm looking forward to your good news!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-940131170
@SivaTharun Hi, since this issue is taking too long, I have submitted a pr #6500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-878348660
Hi:
* Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can subscribe to the developer's email，Mail subscription steps reference https://dolphinscheduler.apache.org/zh-cn/community/development/subscribe.html ,Then write the issue URL in the email content and send question to dev@dolphinscheduler.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] CalvinKirs commented on issue #5807: [Improvement][Dao UT] Use h2 in UT
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #5807:
URL: https://github.com/apache/dolphinscheduler/issues/5807#issuecomment-878777722
Sounds good to me .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org