[GitHub] [accumulo-examples] dlmarion commented on a diff in pull request #96: Update tracing example to use new OpenTelemetry tracing objects

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #96:
URL: https://github.com/apache/accumulo-examples/pull/96#discussion_r844249029


##########
src/main/java/org/apache/accumulo/examples/client/TracingExample.java:
##########
@@ -75,7 +75,7 @@ private TracingExample(AccumuloClient client) {
   }
 
   private void enableTracing() {
-    // DistributedTrace.enable("myHost", "myApp");
+    TraceUtil.enable();

Review Comment:
   > because this is an example for end user code, we should avoid TraceUtil, and make calls directly to OpenTelemetry, as needed
   
   I think I misunderstood the usage of this example. I don't think we should maintain an example for how to use OpenTelemetry. There is better documentation and better examples at https://opentelemetry.io/docs/instrumentation/java/. I think we should remove this example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org