You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "twz915 (via GitHub)" <gi...@apache.org> on 2023/01/31 08:53:26 UTC

[GitHub] [rocketmq-client-go] twz915 opened a new pull request, #988: support unit producer/consumer

twz915 opened a new pull request, #988:
URL: https://github.com/apache/rocketmq-client-go/pull/988

   ## What is the purpose of the change
   
   Support unit producer/consumer.
   Supports consuming messages from Unit2 in Unit1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-client-go] twz915 commented on pull request #988: support unit producer/consumer

Posted by "twz915 (via GitHub)" <gi...@apache.org>.
twz915 commented on PR #988:
URL: https://github.com/apache/rocketmq-client-go/pull/988#issuecomment-1409990423

   https://github.com/apache/rocketmq-client-go/issues/989


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #988: [ISSUE #989] support unit producer/consumer

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #988:
URL: https://github.com/apache/rocketmq-client-go/pull/988#issuecomment-1410062081

   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/988?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#988](https://codecov.io/gh/apache/rocketmq-client-go/pull/988?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a92798) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/896a8a3453be4bcfcb5bfb5bb9139c4df6d4cdab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (896a8a3) will **decrease** coverage by `0.07%`.
   > The diff coverage is `15.15%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #988      +/-   ##
   ==========================================
   - Coverage   23.32%   23.26%   -0.07%     
   ==========================================
     Files          52       52              
     Lines        7266     7294      +28     
   ==========================================
   + Hits         1695     1697       +2     
   - Misses       5339     5363      +24     
   - Partials      232      234       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [consumer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvb3B0aW9uLmdv) | `18.18% <0.00%> (-1.66%)` | :arrow_down: |
   | [producer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvb3B0aW9uLmdv) | `32.87% <0.00%> (-5.84%)` | :arrow_down: |
   | [primitive/nsresolver.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJpbWl0aXZlL25zcmVzb2x2ZXIuZ28=) | `53.09% <55.55%> (-1.11%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-client-go] ShannonDing merged pull request #988: [ISSUE #989] consumer and producer client add unit support (WithUnitName)

Posted by "ShannonDing (via GitHub)" <gi...@apache.org>.
ShannonDing merged PR #988:
URL: https://github.com/apache/rocketmq-client-go/pull/988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-client-go] twz915 commented on pull request #988: [ISSUE #989] support unit producer/consumer

Posted by "twz915 (via GitHub)" <gi...@apache.org>.
twz915 commented on PR #988:
URL: https://github.com/apache/rocketmq-client-go/pull/988#issuecomment-1411345443

   @codecov-commenter 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org