You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/31 14:01:36 UTC

[GitHub] [airflow] eladkal opened a new issue, #27409: Improve error message when branched task_id does not exist

eladkal opened a new issue, #27409:
URL: https://github.com/apache/airflow/issues/27409

   ### Body
   
   This issue is to handle the TODO left in the code:
   https://github.com/apache/airflow/blob/64174ce25ae800a38e712aa0bd62a5893ea2ff99/airflow/operators/python.py#L211
   
   Related: https://github.com/apache/airflow/pull/18471/files#r716030104
   
   Currently now only BranchPythonOperator will show informed error message when the requested branched task_id does not exist other branch operators will show :
   ```
     File "/usr/local/lib/python3.9/site-packages/airflow/models/skipmixin.py", line 147, in skip_all_except
       branch_task_ids = set(branch_task_ids)
   TypeError: 'NoneType' object is not iterable
   ```
   
   This task is to generalize the solution of https://github.com/apache/airflow/pull/20411 to all branch operators.
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #27409: Improve error message when branched task_id does not exist

Posted by GitBox <gi...@apache.org>.
potiuk closed issue #27409: Improve error message when branched task_id does not exist
URL: https://github.com/apache/airflow/issues/27409


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #27409: Improve error message when branched task_id does not exist

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #27409:
URL: https://github.com/apache/airflow/issues/27409#issuecomment-1297242368

   > Maybe we should strive to remove all TODOs and have pre-commit for that :). ?
   
   I think TODO are OK.. we just need to go over them once in a while
   We have some from 2017
   https://github.com/apache/airflow/blob/126b7b8a073f75096d24378ffd749ce166267826/airflow/config_templates/airflow_local_settings.py#L29-L33


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #27409: Improve error message when branched task_id does not exist

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #27409:
URL: https://github.com/apache/airflow/issues/27409#issuecomment-1297171643

   Oh. yeah. 
   
   I read recently an advice - never leave TODOs in the code except while you are iterating on thoe code - always convert TODO to issues !
   
   Maybe we should strive to remove all TODOs and have pre-commit for that :). ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] o-nikolas commented on issue #27409: Improve error message when branched task_id does not exist

Posted by GitBox <gi...@apache.org>.
o-nikolas commented on issue #27409:
URL: https://github.com/apache/airflow/issues/27409#issuecomment-1299538700

   > > Maybe we should strive to remove all TODOs and have pre-commit for that :). ?
   > 
   > I think TODO are OK.. we just need to go over them once in a while We have some from 2017
   > 
   
   I land somewhere in the middle, I think they're okay sometimes, but if you do commit a TODO it should _always_ have an associated Issue created and mentioned/linked in the TODO (IMHO)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org