You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2008/03/08 22:59:47 UTC

[PATCH] Support Libtool >=2.2

Libtool 2.* is slightly incompatible with Libtool 1.*.
I'm attaching a patch which allows to build Subversion with Libtool 2.2, but
it unfortunately doesn't work with Libtool 1.*.

[[[
Fix building with Libtool 2.2.

* autogen.sh:
  Copy ltoptions.m4, ltsugar.m4, ltversion.m4 and lt~obsolete.m4 to build.
* configure.ac:
  Replace deprecated AC_PROG_LIBTOOL with LT_INIT. Require Libtool >=2.2.
* aclocal.m4:
  Include ltoptions.m4, ltsugar.m4, ltversion.m4 and lt~obsolete.m4.
]]]

-- 
Arfrever Frehtes Taifersar Arahesis

Re: [PATCH] Support Libtool >=2.2

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-03-08 23:59:24 Arfrever Frehtes Taifersar Arahesis napisał(a):
> Libtool 2.* is slightly incompatible with Libtool 1.*.
> I'm attaching a patch which allows to build Subversion with Libtool 2.2, but
> it unfortunately doesn't work with Libtool 1.*.
> 
> [[[
> Fix building with Libtool 2.2.
> 
> * autogen.sh:
>   Copy ltoptions.m4, ltsugar.m4, ltversion.m4 and lt~obsolete.m4 to build.

Explanation:
Libtool-2.2's libtool.m4 contains this fragment:
dnl aclocal doesn't pull ltoptions.m4, ltsugar.m4, or ltversion.m4
dnl unless we require an AC_DEFUNed macro:
AC_REQUIRE([LTOPTIONS_VERSION])dnl
AC_REQUIRE([LTSUGAR_VERSION])dnl
AC_REQUIRE([LTVERSION_VERSION])dnl
AC_REQUIRE([LTOBSOLETE_VERSION])dnl

-- 
Arfrever Frehtes Taifersar Arahesis

Re: [PATCH] Support Libtool >=2.2

Posted by Eric Gillespie <ep...@pretzelnet.org>.
"Arfrever Frehtes Taifersar Arahesis" <ar...@gmail.com> writes:

> Which version of libtool do you have?

New info: it consistently works for the libtool 1.5.22 Ubuntu
Dapper comes with, and consistently fails for the libtool 1.5.24
I have in /usr/local.

So, false alarm, I guess?  Sigh, I hate libtool.

-- 
Eric Gillespie <*> epg@pretzelnet.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Support Libtool >=2.2

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-04-01 19:04 Eric Gillespie <ep...@pretzelnet.org>:
> Eric Gillespie <ep...@google.com> writes:
>
>  > Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> writes:
>  >
>  > > In r29925 I committed improved patch which seems to work with Libtool 1.*.
>  >
>  > I'm not the right person to review this, really, but it looks OK
>  > to me.  I can confirm it still works with libtool 1.x (tested
>  > with 1.5.22).
>
>  I was wrong.  I suppose my working copy was not sufficiently
>  clean, as I noticed the problem with a fresh checkout.  A fresh
>  checkout of 29924 works.  Update it to 29925 and it still works.
>  But fresh checkout of r29925 or later breaks:
>
>  0 test-29925% make
>  /bin/sh /home/epg/work/svn/test-29925/libtool --silent --mode=compile /opt/gcc-4.2/bin/gcc -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE  -I/opt/httpd/include   -I/opt/httpd/include   -g -Wall --std=c89 -g -pthread -D_LARGEFILE64_SOURCE -DNE_LFS -Wpointer-arith -Wwrite-strings -Wshadow  -DSVN_DEBUG -DAP_DEBUG  -I./subversion/include -I./subversion -I/usr/include/neon -I/opt/httpd/include   -I/opt/httpd/include  -I/usr/local/include/serf-0  -o subversion/libsvn_delta/cancel.lo -c subversion/libsvn_delta/cancel.c
>  /bin/sh: /home/epg/work/svn/test-29925/libtool: No such file or directory
>  make: *** [subversion/libsvn_delta/cancel.lo] Error 127

Which version of libtool do you have?
Could you check rHEAD?

(I was testing fresh checkouts of r>=29930 with libtool-1.5.26 and I
didn't notice any problems.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Support Libtool >=2.2

Posted by Eric Gillespie <ep...@pretzelnet.org>.
Eric Gillespie <ep...@google.com> writes:

> Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> writes:
> 
> > In r29925 I committed improved patch which seems to work with Libtool 1.*.
> 
> I'm not the right person to review this, really, but it looks OK
> to me.  I can confirm it still works with libtool 1.x (tested
> with 1.5.22).

I was wrong.  I suppose my working copy was not sufficiently
clean, as I noticed the problem with a fresh checkout.  A fresh
checkout of 29924 works.  Update it to 29925 and it still works.
But fresh checkout of r29925 or later breaks:

0 test-29925% make
/bin/sh /home/epg/work/svn/test-29925/libtool --silent --mode=compile /opt/gcc-4.2/bin/gcc -DLINUX=2 -D_REENTRANT -D_GNU_SOURCE -D_LARGEFILE64_SOURCE  -I/opt/httpd/include   -I/opt/httpd/include   -g -Wall --std=c89 -g -pthread -D_LARGEFILE64_SOURCE -DNE_LFS -Wpointer-arith -Wwrite-strings -Wshadow  -DSVN_DEBUG -DAP_DEBUG  -I./subversion/include -I./subversion -I/usr/include/neon -I/opt/httpd/include   -I/opt/httpd/include  -I/usr/local/include/serf-0  -o subversion/libsvn_delta/cancel.lo -c subversion/libsvn_delta/cancel.c
/bin/sh: /home/epg/work/svn/test-29925/libtool: No such file or directory
make: *** [subversion/libsvn_delta/cancel.lo] Error 127

-- 
Eric Gillespie <*> epg@pretzelnet.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Support Libtool >=2.2

Posted by Eric Gillespie <ep...@google.com>.
Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> writes:

> In r29925 I committed improved patch which seems to work with Libtool 1.*.

I'm not the right person to review this, really, but it looks OK
to me.  I can confirm it still works with libtool 1.x (tested
with 1.5.22).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Support Libtool >=2.2

Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-03-08 23:59:24 Arfrever Frehtes Taifersar Arahesis napisał(a):
> Libtool 2.* is slightly incompatible with Libtool 1.*.
> I'm attaching a patch which allows to build Subversion with Libtool 2.2, but
> it unfortunately doesn't work with Libtool 1.*.
> 
> [[[
> Fix building with Libtool 2.2.
> 
> * autogen.sh:
>   Copy ltoptions.m4, ltsugar.m4, ltversion.m4 and lt~obsolete.m4 to build.
> * configure.ac:
>   Replace deprecated AC_PROG_LIBTOOL with LT_INIT. Require Libtool >=2.2.
> * aclocal.m4:
>   Include ltoptions.m4, ltsugar.m4, ltversion.m4 and lt~obsolete.m4.
> ]]]
> 

In r29925 I committed improved patch which seems to work with Libtool 1.*.

-- 
Arfrever Frehtes Taifersar Arahesis