You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Quinn Leng <qu...@gmail.com> on 2017/07/18 21:15:47 UTC
Re: Review Request 60847: Added test cases for /slaves,
/slave/containers, /frameworks endpoints.
> On July 18, 2017, 8:23 p.m., Greg Mann wrote:
> > src/tests/master_tests.cpp
> > Lines 2523-2524 (patched)
> > <https://reviews.apache.org/r/60847/diff/3/?file=1778679#file1778679line2523>
> >
> > Newline here.
It makes the code look a little strange, one single line of comment surrounded by two empty lines.
> On July 18, 2017, 8:23 p.m., Greg Mann wrote:
> > src/tests/master_tests.cpp
> > Line 5866 (original), 5980-5981 (patched)
> > <https://reviews.apache.org/r/60847/diff/3/?file=1778679#file1778679line6001>
> >
> > Newline after this comment.
It makes the code look a little strange, one single line of comment surrounded by two empty lines.
- Quinn
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60847/#review180852
-----------------------------------------------------------
On July 18, 2017, 6:28 p.m., Quinn Leng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60847/
> -----------------------------------------------------------
>
> (Updated July 18, 2017, 6:28 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added query parameter test cases for '/slaves' and '/frameworks' on
> the master, and '/slave/containers' endpoint on the slave.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 6e6461c2e13c3eb055aa3c2d8ad8e3ac54a1d197
> src/tests/slave_tests.cpp 035db18db3a64a9e358c1c54cc18a4bdeb85d8bf
>
>
> Diff: https://reviews.apache.org/r/60847/diff/4/
>
>
> Testing
> -------
>
> Passed 'make check -j48'
> Passed 'GTEST_FILTER="MasterTest.FrameworksEndpointQueryFramework" make check -j48'
> Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.FrameworksEndpointQueryFramework" --gtest_repeat=1000 --gtest_break_on_failure'
> Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48'
> Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave" --gtest_repeat=1000 --gtest_break_on_failure'
>
>
> Thanks,
>
> Quinn Leng
>
>