[GitHub] [sling-org-apache-sling-feature-cpconverter] DominikSuess commented on a change in pull request #28: Feature Converter doesn't cleanup after itself

[GitBox <gi...@apache.org>]

DominikSuess commented on a change in pull request #28:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#discussion_r431292982



##########
File path: src/main/java/org/apache/sling/feature/cpconverter/cli/ShutDownHook.java
##########
@@ -76,4 +82,15 @@ public void run() {
         logger.info("+-----------------------------------------------------+");
     }
 
+    private void cleanUp(){
+        String tmpDir = System.getProperty("java.io.tmpdir");
+        logger.info("Cleaning up tmp directories {}, {}", tmpDir + "sub-content-packages", tmpDir + "syntethic-content-packages" );

Review comment:
       @kaushalmall - just a minor thing - tmpdir may not have separator at the end so the error message may actually not really return the right path, creating the the Dir fileobjects ahead and using the path out of those would be cleaner. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org