You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/07/20 17:53:42 UTC

[Impala-ASF-CR] IMPALA-11441: Address upsert test failure by reverting KUDU-1644

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18762


Change subject: IMPALA-11441: Address upsert test failure by reverting KUDU-1644
......................................................................

IMPALA-11441: Address upsert test failure by reverting KUDU-1644

The fix for KUDU-1644 has been linked to test failures
on TestKuduBasicDML.test_kudu_upsert. This updates the
toolchain to use a custom Kudu that is equivalent
to upstream dc4031f693 plus a revert of KUDU-1644.
The custom Kudu branch is located at:
https://github.com/joemcdonnell/kudu/tree/impala11441
This is a temporary workaround until upstream Kudu
merges a fix.

Testing:
 - Ran a core job

Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
---
M bin/impala-config.sh
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/18762/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
Gerrit-Change-Number: 18762
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11441: Address upsert test failure by reverting KUDU-1644

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18762 )

Change subject: IMPALA-11441: Address upsert test failure by reverting KUDU-1644
......................................................................

IMPALA-11441: Address upsert test failure by reverting KUDU-1644

The fix for KUDU-1644 has been linked to test failures
on TestKuduBasicDML.test_kudu_upsert. This updates the
toolchain to use a custom Kudu that is equivalent
to upstream dc4031f693 plus a revert of KUDU-1644.
The custom Kudu branch is located at:
https://github.com/joemcdonnell/kudu/tree/impala11441
This is a temporary workaround until upstream Kudu
merges a fix.

Testing:
 - Ran a core job

Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
Reviewed-on: http://gerrit.cloudera.org:8080/18762
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
Gerrit-Change-Number: 18762
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-11441: Address upsert test failure by reverting KUDU-1644

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18762 )

Change subject: IMPALA-11441: Address upsert test failure by reverting KUDU-1644
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
Gerrit-Change-Number: 18762
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 23:21:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11441: Address upsert test failure by reverting KUDU-1644

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18762 )

Change subject: IMPALA-11441: Address upsert test failure by reverting KUDU-1644
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
Gerrit-Change-Number: 18762
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jul 2022 04:30:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11441: Address upsert test failure by reverting KUDU-1644

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18762 )

Change subject: IMPALA-11441: Address upsert test failure by reverting KUDU-1644
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8343/


-- 
To view, visit http://gerrit.cloudera.org:8080/18762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
Gerrit-Change-Number: 18762
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 23:07:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11441: Address upsert test failure by reverting KUDU-1644

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18762 )

Change subject: IMPALA-11441: Address upsert test failure by reverting KUDU-1644
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8345/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
Gerrit-Change-Number: 18762
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 23:21:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11441: Address upsert test failure by reverting KUDU-1644

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18762 )

Change subject: IMPALA-11441: Address upsert test failure by reverting KUDU-1644
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10998/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
Gerrit-Change-Number: 18762
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 18:14:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11441: Address upsert test failure by reverting KUDU-1644

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18762 )

Change subject: IMPALA-11441: Address upsert test failure by reverting KUDU-1644
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8343/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
Gerrit-Change-Number: 18762
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 18:16:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11441: Address upsert test failure by reverting KUDU-1644

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18762 )

Change subject: IMPALA-11441: Address upsert test failure by reverting KUDU-1644
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
Gerrit-Change-Number: 18762
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 19:17:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11441: Address upsert test failure by reverting KUDU-1644

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18762 )

Change subject: IMPALA-11441: Address upsert test failure by reverting KUDU-1644
......................................................................


Patch Set 1:

The test failure is unrelated. Retrying


-- 
To view, visit http://gerrit.cloudera.org:8080/18762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id183eb6daa8e750254bdd2b0eaa925e8e54f16d5
Gerrit-Change-Number: 18762
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 23:20:32 +0000
Gerrit-HasComments: No