[jira] [Commented] (HTRACE-220) htraced: should be able to set log.path to the empty string via "-Dlog.path=" on the command line

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14643769#comment-14643769 ] 

Colin Patrick McCabe commented on HTRACE-220:
---------------------------------------------

This issue only affects command-line options passed into htraced or the htrace tool via the command-line.  The issue is basically that we translate {{-Dfoo=}} into {{-Dfoo=true}}.  This translation was done to make boolean configuration variables work better.  But it effectively prevents setting {{log.path}} to the empty string, needed to see log output on stdout.

This patch fixes it to set foo to the empty string when it sees {{-Dfoo=}}.  We continue to translate {{-Dfoo}} (no equals sign on the end) to {{-Dfoo=true}} because this is good for boolean configuration values.  I also added a new unit test.

> htraced: should be able to set log.path to the empty string via "-Dlog.path=" on the command line
> -------------------------------------------------------------------------------------------------
>
>                 Key: HTRACE-220
>                 URL: https://issues.apache.org/jira/browse/HTRACE-220
>             Project: HTrace
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-220.001.patch
>
>
> htraced: should be able to set {{log.path}} to the empty string via "-Dlog.path=" on the command line



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)