You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2021/03/16 02:32:47 UTC
[GitHub] [bigtop] JunHe77 opened a new pull request #759: BIGTOP-3526: Remove phantomjs depdency from yar-ui
JunHe77 opened a new pull request #759:
URL: https://github.com/apache/bigtop/pull/759
Haoop Yarn-UI depends on phantomjs (optional) while there is
not prebuilt binary other than x86 platform. And this will
cause hadoop build failure as yarn-ui has been enabled by BIGTOP-3456.
Change-Id: I10d034d3172787f9667d53d44b1663a04c9fdf93
Signed-off-by: Jun He <ju...@arm.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] jojochuang commented on pull request #759: BIGTOP-3526: Remove phantomjs dependency from yarn-ui
Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #759:
URL: https://github.com/apache/bigtop/pull/759#issuecomment-846359107
(FWIW, Ubuntu Bionic and Focal have official phantomjs binary packages for ARM) HADOOP-17723 / https://github.com/apache/hadoop/pull/3037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #759: BIGTOP-3526: Remove phantomjs dependency from yarn-ui
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #759:
URL: https://github.com/apache/bigtop/pull/759#issuecomment-846971434
Thanks, @jojochuang. The information is useful for Bigtop too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #759: BIGTOP-3526: Remove phantomjs depdency from yar-ui
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #759:
URL: https://github.com/apache/bigtop/pull/759#issuecomment-800120922
Since the PhantomJS is only used for testing, removing it would be ok. Yarn UI 2 built with the modified yarn.lock worked for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims merged pull request #759: BIGTOP-3526: Remove phantomjs dependency from yarn-ui
Posted by GitBox <gi...@apache.org>.
iwasakims merged pull request #759:
URL: https://github.com/apache/bigtop/pull/759
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on a change in pull request #759: BIGTOP-3526: Remove phantomjs depdency from yar-ui
Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #759:
URL: https://github.com/apache/bigtop/pull/759#discussion_r595017794
##########
File path: bigtop-packages/src/common/hadoop/do-component-build
##########
@@ -125,6 +125,8 @@ MAVEN_OPTS+="-DskipTests -DskipTest -DskipITs "
. $(dirname ${0})/maven_deploy.sh
# Build artifacts
+# remove phantomjs dependency
+sed -i '/^phantomjs-prebuilt/,+12d;N;/phantomjs/!P;D' hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/yarn.lock
Review comment:
Should we use `patch*.diff` file rather than ad hoc editing in the do-component-build? I think the sed scripting is possible to modify the file in unexpected way if the yarn.lock is updated (on Hadoop side).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] JunHe77 commented on a change in pull request #759: BIGTOP-3526: Remove phantomjs dependency from yarn-ui
Posted by GitBox <gi...@apache.org>.
JunHe77 commented on a change in pull request #759:
URL: https://github.com/apache/bigtop/pull/759#discussion_r595664365
##########
File path: bigtop-packages/src/common/hadoop/do-component-build
##########
@@ -125,6 +125,8 @@ MAVEN_OPTS+="-DskipTests -DskipTest -DskipITs "
. $(dirname ${0})/maven_deploy.sh
# Build artifacts
+# remove phantomjs dependency
+sed -i '/^phantomjs-prebuilt/,+12d;N;/phantomjs/!P;D' hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/yarn.lock
Review comment:
That should be a better way. I'll upload a new patchset. Thanks, @iwasakims
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org