You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ishan Chattopadhyaya (JIRA)" <ji...@apache.org> on 2014/12/22 21:04:14 UTC
[jira] [Comment Edited] (SOLR-6797) Add
score=degrees|kilometers|miles for AbstractSpatialFieldType
[ https://issues.apache.org/jira/browse/SOLR-6797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256123#comment-14256123 ]
Ishan Chattopadhyaya edited comment on SOLR-6797 at 12/22/14 8:03 PM:
----------------------------------------------------------------------
Thanks for your review, David.
I've incorporated your suggestions in the attached patch. This unsets and ignores/doesn't use the "units" param (checks for "degrees" for backcompat behaviour), introduces an optional param "distanceUnits" (if someone wants to specify units explicitly).
I'm still writing the tests, will update the patch soon.
was (Author: ichattopadhyaya):
Thanks for your review, David.
I've incorporated your suggestions in the attached patch. This retains "units" as an optional param for backcompat behaviour, introduced an optional param "distanceUnits" (if someone wants to specify units explicitly).
I'm still writing the tests, will update the patch soon.
> Add score=degrees|kilometers|miles for AbstractSpatialFieldType
> ---------------------------------------------------------------
>
> Key: SOLR-6797
> URL: https://issues.apache.org/jira/browse/SOLR-6797
> Project: Solr
> Issue Type: Improvement
> Components: spatial
> Reporter: David Smiley
> Attachments: SOLR-6797.patch, SOLR-6797.patch
>
>
> Annoyingly, the units="degrees" attribute is required for fields extending AbstractSpatialFieldType (e.g. RPT, BBox). And it doesn't really have any effect. I propose the following:
> * Simply drop the attribute; ignore it if someone sets it to "degrees" (for back-compat).
> * When using score="distance", or score=area or area2D (as seen in BBoxField) then use kilometers if geo=true, otherwise degrees.
> * Add support for score=degrees|kilometers|miles|degrees
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org