You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by gn...@apache.org on 2017/09/29 07:25:36 UTC
[5/9] karaf git commit: Turn Feature.VERSION_SEPARATOR into a char
Turn Feature.VERSION_SEPARATOR into a char
String.indexOf(char) is faster than String.indexOf(String), so use
char for VERSION_SEPARATOR.
Signed-off-by: Robert Varga <ni...@hq.sk>
Project: http://git-wip-us.apache.org/repos/asf/karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/826cf5c2
Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/826cf5c2
Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/826cf5c2
Branch: refs/heads/master
Commit: 826cf5c205009a8e2b88fba9b43ea67623bdb802
Parents: 8228021
Author: Robert Varga <ni...@hq.sk>
Authored: Mon Sep 25 11:54:31 2017 +0200
Committer: Robert Varga <ni...@hq.sk>
Committed: Wed Sep 27 10:43:57 2017 +0200
----------------------------------------------------------------------
.../java/org/apache/karaf/features/internal/model/Feature.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/karaf/blob/826cf5c2/features/core/src/main/java/org/apache/karaf/features/internal/model/Feature.java
----------------------------------------------------------------------
diff --git a/features/core/src/main/java/org/apache/karaf/features/internal/model/Feature.java b/features/core/src/main/java/org/apache/karaf/features/internal/model/Feature.java
index 9e838e6..54a739b 100644
--- a/features/core/src/main/java/org/apache/karaf/features/internal/model/Feature.java
+++ b/features/core/src/main/java/org/apache/karaf/features/internal/model/Feature.java
@@ -78,7 +78,7 @@ import org.apache.felix.utils.version.VersionCleaner;
})
public class Feature extends Content implements org.apache.karaf.features.Feature {
- public static final String VERSION_SEPARATOR = "/";
+ public static final char VERSION_SEPARATOR = '/';
public static final String DEFAULT_VERSION = "0.0.0";
@XmlElement(name = "details", namespace=org.apache.karaf.features.FeaturesNamespaces.URI_CURRENT)
@@ -130,7 +130,7 @@ public class Feature extends Content implements org.apache.karaf.features.Featur
int idx = str.indexOf(VERSION_SEPARATOR);
if (idx >= 0) {
String strName = str.substring(0, idx);
- String strVersion = str.substring(idx + VERSION_SEPARATOR.length(), str.length());
+ String strVersion = str.substring(idx + 1, str.length());
return new Feature(strName, strVersion);
} else {
return new Feature(str);