You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/04/15 15:11:13 UTC
[GitHub] [couchdb] nickva commented on a change in pull request #2777:
report changes stats intermittently
nickva commented on a change in pull request #2777: report changes stats intermittently
URL: https://github.com/apache/couchdb/pull/2777#discussion_r408919549
##########
File path: src/chttpd/src/chttpd_stats.erl
##########
@@ -24,29 +24,38 @@
incr_writes/1,
incr_rows/0,
- incr_rows/1
+ incr_rows/1,
+
+ update_interval/1
]).
-record(st, {
reads = 0,
writes = 0,
- rows = 0
+ rows = 0,
+ last_report_ts = 0,
+ interval,
+ request
}).
-define(KEY, chttpd_stats).
+-define(INTERVAL, 60).
Review comment:
Let's add _SEC suffix to make it clear these are seconds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services