You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2017/08/21 09:56:18 UTC

Review Request 61779: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61779/
-----------------------------------------------------------

Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.


Bugs: RANGER-1676
    https://issues.apache.org/jira/browse/RANGER-1676


Repository: ranger


Description
-------

Policy Details popup from Access audit page (The popup which is displayed when we click on the respective PolicyId of audit item) is not displaying details of masking / row filter policy.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 140a59d 
  security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java e94bad4 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4bac746 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 0d8e3df 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 68be81e 
  security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6ff5329 


Diff: https://reviews.apache.org/r/61779/diff/1/


Testing
-------

Verified :
(Policy details popup comes when user click on the rows of access log table under the Access Tab -> Audit Menu)

1.User able to see masking and row filter policy details on policy detail popup.
2.Policy Versions are getting updated and displayed correctly on policy details popup.
3.Also tested with existing access logs.


Thanks,

Nitin Galave


Re: Review Request 61779: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61779/#review183427
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Aug. 21, 2017, 10 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61779/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2017, 10 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1676
>     https://issues.apache.org/jira/browse/RANGER-1676
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Policy Details popup from Access audit page (The popup which is displayed when we click on the respective PolicyId of audit item) is not displaying details of masking / row filter policy.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 140a59d 
>   security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java e94bad4 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4bac746 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 0d8e3df 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 68be81e 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6ff5329 
> 
> 
> Diff: https://reviews.apache.org/r/61779/diff/1/
> 
> 
> Testing
> -------
> 
> Verified :
> (Policy details popup comes when user click on the rows of access log table under the Access Tab -> Audit Menu)
> 
> 1.User able to see masking and row filter policy details on policy detail popup.
> 2.Policy Versions are getting updated and displayed correctly on policy details popup.
> 3.Also tested with existing access logs.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Re: Review Request 61779: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61779/#review183447
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Aug. 21, 2017, 10 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61779/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2017, 10 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1676
>     https://issues.apache.org/jira/browse/RANGER-1676
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Policy Details popup from Access audit page (The popup which is displayed when we click on the respective PolicyId of audit item) is not displaying details of masking / row filter policy.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 140a59d 
>   security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java e94bad4 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4bac746 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 0d8e3df 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 68be81e 
>   security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6ff5329 
> 
> 
> Diff: https://reviews.apache.org/r/61779/diff/1/
> 
> 
> Testing
> -------
> 
> Verified :
> (Policy details popup comes when user click on the rows of access log table under the Access Tab -> Audit Menu)
> 
> 1.User able to see masking and row filter policy details on policy detail popup.
> 2.Policy Versions are getting updated and displayed correctly on policy details popup.
> 3.Also tested with existing access logs.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Re: Review Request 61779: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61779/
-----------------------------------------------------------

(Updated Aug. 21, 2017, 10 a.m.)


Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.


Bugs: RANGER-1676
    https://issues.apache.org/jira/browse/RANGER-1676


Repository: ranger


Description
-------

Policy Details popup from Access audit page (The popup which is displayed when we click on the respective PolicyId of audit item) is not displaying details of masking / row filter policy.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 140a59d 
  security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java e94bad4 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4bac746 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js 0d8e3df 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 68be81e 
  security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html 6ff5329 


Diff: https://reviews.apache.org/r/61779/diff/1/


Testing
-------

Verified :
(Policy details popup comes when user click on the rows of access log table under the Access Tab -> Audit Menu)

1.User able to see masking and row filter policy details on policy detail popup.
2.Policy Versions are getting updated and displayed correctly on policy details popup.
3.Also tested with existing access logs.


Thanks,

Nitin Galave