You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/12/15 18:12:05 UTC
[GitHub] [daffodil-site] stevedlawrence opened a new pull request, #102: Update release artifact and checksum URLs
stevedlawrence opened a new pull request, #102:
URL: https://github.com/apache/daffodil-site/pull/102
The closer.lua page does not provide any information we don't already provide. The mirrors that it used to list have been replaced by a CDN, and we provide a message and link describing how to verify downloads on our download page. This has also been known to cause issues when users try to wget/curl a download link, since they just download an HTML page instead of the actual intended artifact, causing confusing about failed installations or invalid gpg signatures or checksums.
To avoid this issues, for apache release artifcts using closer.lua, this now appends ?action=download to the end of the URL so the download links skip the normal closer.lua page and instead download straight from the CDN.
Additionally, closer.lua is aware of archived artifacts, so we can use the same URL for archived and non-archived URLs. The downloads.apache.org URL is aware of archived .sha512 and .asc release artifacts, so these too can use the same URL for all releases. By using these URLs, we no longer need to update previous release pages when they are archived. We just need to delete old releases from dist.apache.org and the links will automatically redirect to the archives, removing one manual step from the release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] stevedlawrence commented on pull request #102: Update release artifact and checksum URLs
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #102:
URL: https://github.com/apache/daffodil-site/pull/102#issuecomment-1362163386
And right after I updated the PR infra pushed the change to support a download path to support wget. PR has been updated to use the new link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] tuxji commented on a diff in pull request #102: Update release artifact and checksum URLs
Posted by GitBox <gi...@apache.org>.
tuxji commented on code in PR #102:
URL: https://github.com/apache/daffodil-site/pull/102#discussion_r1050003339
##########
site/_layouts/release.html:
##########
@@ -45,6 +45,7 @@ <h4>Source</h4>
checksum-root=page.checksum-root
artifact-root=page.artifact-root
prefix=prefix
+ apache=page.apache
Review Comment:
I assume the reason for this new line is to make the params conditional?
##########
site/_includes/download-list.html:
##########
@@ -1,7 +1,8 @@
{% for file in include.artifacts %}
<div class="row">
<div class="col-sm-6">
- <a href="{{ include.artifact-root | append: include.prefix | append: file }}">{{ file }}</a>
+ {% if include.apache %} {% assign params = "?action=download" %} {% endif %}
+ <a href="{{ include.artifact-root | append: include.prefix | append: file | append: params }}">{{ file }}</a>
Review Comment:
Why make the params conditional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] stevedlawrence commented on pull request #102: Update release artifact and checksum URLs
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #102:
URL: https://github.com/apache/daffodil-site/pull/102#issuecomment-1362061576
Infra has not done anything to avoid the wget problem that I've seen. But I've updated this PR to change how links work to simplify the release pages a bit. Once Infra does support a wget solution, it should just be a one line change.
Please take another look and make sure this seems okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] stevedlawrence merged pull request #102: Update release artifact and checksum URLs
Posted by GitBox <gi...@apache.org>.
stevedlawrence merged PR #102:
URL: https://github.com/apache/daffodil-site/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] stevedlawrence commented on pull request #102: Update release artifact and checksum URLs
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #102:
URL: https://github.com/apache/daffodil-site/pull/102#issuecomment-1355364199
> Maybe consider mentioning the curl -o, --output file and wget -O, --output-document=file options to avoid needing to rename a file after downloading it in the release.html and vscode.html files already being modified by this pull request?
@tuxji, These -o options still require a user to know/duplicate the name, right? For example, using wget would have to look like this:
```
wget -o apache-daffodil-3.4.0-bin.tgz https://www.apache.org/dyn/closer.lua/daffodil/3.4.0/bin/apache-daffodil-3.4.0-bin.tgz?action=download
```
I was hoping there would be an option to cause wget/curl drop the query parameters. I've found wget has a `--content-disposition` flag which seems to work, but the wget man page says it's experimental. And supposedly `curl -OJ` should do this, but doesn't seem to work for me.
Alternatively we could ask infra (or propose or PR) to add a URL that enables action=download by default. Seems like it could be done with a RewriteRule or couple line patch, but I'm also not sure if it's worth the hassle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] stevedlawrence commented on a diff in pull request #102: Update release artifact and checksum URLs
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #102:
URL: https://github.com/apache/daffodil-site/pull/102#discussion_r1050009014
##########
site/_includes/download-list.html:
##########
@@ -1,7 +1,8 @@
{% for file in include.artifacts %}
<div class="row">
<div class="col-sm-6">
- <a href="{{ include.artifact-root | append: include.prefix | append: file }}">{{ file }}</a>
+ {% if include.apache %} {% assign params = "?action=download" %} {% endif %}
+ <a href="{{ include.artifact-root | append: include.prefix | append: file | append: params }}">{{ file }}</a>
Review Comment:
On our download page we list both Apache releases and non-Apache release made before Daffodil joined the apache incubator. This condition makes it so only releases made after that get the `?action=download` thing. The `page.apache` thing is a flag in each release page that says whether or not it's one of these Apache release.
##########
site/_layouts/release.html:
##########
@@ -45,6 +45,7 @@ <h4>Source</h4>
checksum-root=page.checksum-root
artifact-root=page.artifact-root
prefix=prefix
+ apache=page.apache
Review Comment:
Yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] stevedlawrence commented on pull request #102: Update release artifact and checksum URLs
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #102:
URL: https://github.com/apache/daffodil-site/pull/102#issuecomment-1355518268
Actually, discussion about this change ended up on the #asfinfra slack, which led to this wget problem, and one approach has been proposed to fix the wget issue: [infrastructure-p6/pull/1346](https://togithub.com/apache/infrastructure-p6/pull/1346). So `/download/` is prepended to the URL file path instead of appending `?action=download`.
I'll give this PR a few more days to marinate, and if infra adopts this change or something similar then I'll update the PR to use the new download link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-site] tuxji commented on pull request #102: Update release artifact and checksum URLs
Posted by GitBox <gi...@apache.org>.
tuxji commented on PR #102:
URL: https://github.com/apache/daffodil-site/pull/102#issuecomment-1355542658
I ran both curl and wget with debug/verbose options, and there's no content-disposition header from the server so it must've only been coincidence that wget --content-disposition stripped the ?action=download while curl -LOJ left the ?action=download alone. Yes, let's wait a few days to see if infra starts allowing a /download/ prefix to download the file as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org