You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ethan-l-geotab (via GitHub)" <gi...@apache.org> on 2025/12/04 15:39:34 UTC
[PR] feat(SIP-68): Labeled Version History + Restore [superset]
ethan-l-geotab opened a new pull request, #36424:
URL: https://github.com/apache/superset/pull/36424
### SUMMARY
This commit implements the version changes proposed in GitHub issue https://github.com/apache/superset/issues/36145 (SIP-192) to create a way to save a dashboard/chart/dataset state.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
I have a few recordings in the comment sections of the SIP going over how it works.
### TESTING INSTRUCTIONS
1. Save the state of the asset (i'm just going to call them dashboards for now)
<img width="449" height="544" alt="image" src="https://github.com/user-attachments/assets/bec27763-46e1-45f2-b767-41f75cd99d33" />
2. Make changes to the dashboard, add charts, remove charts, change the title
3. Restore the dashboard
4. Check to see if it's actually reverted.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/superset/issues/36145
- [ ] Required feature flags:
VERSION_CONTROL_ENABLED = True
VERSION_RETENTION_LIMIT = 10
- [x] Changes UI: Properties modal has a new button and modal with the version history info
- [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [x] Migration is atomic, supports rollback & is backwards-compatible
- [x] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(SIP-192): Labeled Version History + Restore [superset]
Posted by "dlebedev (via GitHub)" <gi...@apache.org>.
dlebedev commented on PR #36424:
URL: https://github.com/apache/superset/pull/36424#issuecomment-4010040854
Any activity hear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(SIP-68): Labeled Version History + Restore [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36424:
URL: https://github.com/apache/superset/pull/36424#issuecomment-3612856091
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(SIP-192): Labeled Version History + Restore [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #36424:
URL: https://github.com/apache/superset/pull/36424#issuecomment-4785547361
Thanks for building this out @ethan-l-geotab, and for the gracious call on the SIP side. Closing in favor of the SIP-210 direction (#39492) as you suggested, with the version-history goal carried forward there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(SIP-192): Labeled Version History + Restore [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #36424:
URL: https://github.com/apache/superset/pull/36424#issuecomment-3612941234
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/36424?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `39.90385%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.06%. Comparing base ([`92986c2`](https://app.codecov.io/gh/apache/superset/commit/92986c2eccf46ff1fd04e2b257450591cff6110f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c0cd7f9`](https://app.codecov.io/gh/apache/superset/commit/c0cd7f9c4b5d6e5402d3fd0d218bd8ebe005f397?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 27 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/36424?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/version\_control/api.py](https://app.codecov.io/gh/apache/superset/pull/36424?src=pr&el=tree&filepath=superset%2Fversion_control%2Fapi.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmVyc2lvbl9jb250cm9sL2FwaS5weQ==) | 30.28% | [122 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/36424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset/models/version\_history.py](https://app.codecov.io/gh/apache/superset/pull/36424?src=pr&el=tree&filepath=superset%2Fmodels%2Fversion_history.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL3ZlcnNpb25faGlzdG9yeS5weQ==) | 89.65% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/36424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #36424 +/- ##
===========================================
+ Coverage 0 48.06% +48.06%
===========================================
Files 0 636 +636
Lines 0 46946 +46946
Branches 0 5100 +5100
===========================================
+ Hits 0 22564 +22564
- Misses 0 23733 +23733
- Partials 0 649 +649
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/36424/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/36424/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.69% <39.90%> (?)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/36424/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.32% <39.90%> (?)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/36424/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.05% <39.90%> (?)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/36424/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/36424?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(SIP-192): Labeled Version History + Restore [superset]
Posted by "ethan-l-geotab (via GitHub)" <gi...@apache.org>.
ethan-l-geotab commented on PR #36424:
URL: https://github.com/apache/superset/pull/36424#issuecomment-4677225694
Honestly, if the other one is likely to go in, makes sense to reject my open sip and close this one. so as long as we get versioning, I'm happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(SIP-192): Labeled Version History + Restore [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #36424: feat(SIP-192): Labeled Version History + Restore
URL: https://github.com/apache/superset/pull/36424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(SIP-192): Labeled Version History + Restore [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #36424:
URL: https://github.com/apache/superset/pull/36424#issuecomment-4677131027
Nice work here, but SIP-192 (#36145) is still an open proposal, so I'm hesitant to land the implementation before the SIP is accepted. https://github.com/apache/superset/issues/39492 is likely to be voted in, so (as mentioned on that SIP thread) we'd love to know your thoughts or anything you want to point out that isn't covered which your approach tackles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org