You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/21 14:53:21 UTC
[GitHub] [arrow] dragosmg opened a new pull request, #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
dragosmg opened a new pull request, #13680:
URL: https://github.com/apache/arrow/pull/13680
It looks like setting the docker `TZ` to `"MART"` triggers a fail in the Ubuntu CI jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1195785152
Checks are failing (as expected) on the Ubuntu workflow with force tests and:
```r
test_that("force_tests()", {
skip_if_not_running_large_memory_tests()
skip_if_not_dev_mode()
expect_true(FALSE)
})
```
More details:
https://github.com/apache/arrow/runs/7524618548?check_suite_focus=true#step:7:30988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929665850
##########
.github/workflows/r.yml:
##########
@@ -90,9 +90,13 @@ jobs:
run: |
sudo sysctl -w kernel.core_pattern="core.%e.%p"
ulimit -c unlimited
- # Setting a non-default and non-probable Marquesas French Polynesia time
- # it has both with a .45 offset and very very few people who live there.
- archery docker run -e TZ=MART -e ARROW_R_FORCE_TESTS=${{ matrix.force-tests }} ubuntu-r
+ # TZ was set to a non-default and non-probable Marquesas French Polynesia
+ # (it has both with a .45 offset and very very few people who live there)
+ # time here. The build was failing with the following warning (probably
+ # raised to error) in them:
+ # System has not been booted with systemd as init system (PID 1). Can't operate.
+ # Failed to connect to bus: Host is down
+ archery docker run -e TZ="" -e ARROW_R_FORCE_TESTS=${{ matrix.force-tests }} ubuntu-r
Review Comment:
Not sure I follow. This bit is no longer needed as the failure has nothing to do with `TZ`. So I will undo this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13680: ARROW-17166: [R] [CI] force_tests() cannot return TRUE
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1200013986
Benchmark runs are scheduled for baseline = 036fdf2d03c3a6986109f053d94fc237d2c2f82d and contender = 778d574b1aa4d45742cab04c0cc4d71141f0420a. 778d574b1aa4d45742cab04c0cc4d71141f0420a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5888c9d0d78f48fb84ddf6397e46c0d6...3f40488e73354fe188a8034eba0b8b13/)
[Finished :arrow_down:0.54% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/855a3a238323412da568d66b7c5eff5b...230d7df99d064d8da92e9af3feb159d0/)
[Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1c5b866ce5ae4599851a5cab2af77f17...eb6497945a7e43e7b13e88a172ada33b/)
[Finished :arrow_down:0.04% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/06067522aa354256946c45923aedcce6...0ebbdaaeb986466b9d555ca9226ac0cd/)
Buildkite builds:
[Failed] [`778d574b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1228)
[Finished] [`778d574b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1240)
[Failed] [`778d574b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1222)
[Finished] [`778d574b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1242)
[Failed] [`036fdf2d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1227)
[Finished] [`036fdf2d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1239)
[Finished] [`036fdf2d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1221)
[Finished] [`036fdf2d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1241)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1191928530
Revision: 7cac5d9d7f2e7e44b15345963df2a1c2ab228130
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c869e34064](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c869e34064)
|Task|Status|
|----|------|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-linux-gcc-py37-cpu-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-conda-linux-gcc-py37-cpu-r41)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-conda-osx-clang-py37-r40)|
|conda-osx-clang-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-conda-osx-clang-py37-r41)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-conda-win-vs2017-py37-r40)|
|conda-win-vs2017-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-conda-win-vs2017-py37-r41)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-homebrew-r-autobrew)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-homebrew-r-brew)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-r-binary-packages)|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-fedora-r-clang-sanitizer)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-arrow-backwards-compatibility)|
|test-r-depsource-bundled|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-r-depsource-bundled)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-depsource-system)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-dev-duckdb)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-devdocs)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-gcc-11)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-gcc-12)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-linux-as-cran)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-linux-rchk)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-r-minimal-build)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-offline-maximal)|
|test-r-offline-minimal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-r-offline-minimal)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-r-rhub-debian-gcc-release-custom-ccache)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-r-rstudio-r-base-4.1-opensuse153)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-r-rstudio-r-base-4.2-centos7-devtoolset-8)|
|test-r-rstudio-r-base-4.2-focal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-r-rstudio-r-base-4.2-focal)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-ubuntu-22.04)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-c869e34064-github-test-r-versions)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-c869e34064-azure-test-ubuntu-18.04-r-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
dragosmg commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r926809405
##########
.github/workflows/r.yml:
##########
@@ -92,7 +92,7 @@ jobs:
ulimit -c unlimited
# Setting a non-default and non-probable Marquesas French Polynesia time
Review Comment:
If this is an acceptable approach, we should update the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1195854717
Revision: b0290740a4a4ba5ed3bb9dfc6b322cb33be9a457
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0e006be12e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0e006be12e)
|Task|Status|
|----|------|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-linux-gcc-py37-cpu-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-conda-linux-gcc-py37-cpu-r41)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-conda-osx-clang-py37-r40)|
|conda-osx-clang-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-conda-osx-clang-py37-r41)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-conda-win-vs2017-py37-r40)|
|conda-win-vs2017-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-conda-win-vs2017-py37-r41)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-homebrew-r-autobrew)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-homebrew-r-brew)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-r-binary-packages)|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-fedora-r-clang-sanitizer)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-arrow-backwards-compatibility)|
|test-r-depsource-bundled|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-r-depsource-bundled)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-depsource-system)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-dev-duckdb)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-devdocs)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-gcc-11)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-gcc-12)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-linux-as-cran)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-linux-rchk)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-r-minimal-build)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-offline-maximal)|
|test-r-offline-minimal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-r-offline-minimal)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-r-rhub-debian-gcc-release-custom-ccache)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-r-rstudio-r-base-4.1-opensuse153)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-r-rstudio-r-base-4.2-centos7-devtoolset-8)|
|test-r-rstudio-r-base-4.2-focal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-r-rstudio-r-base-4.2-focal)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-ubuntu-22.04)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-0e006be12e-github-test-r-versions)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-0e006be12e-azure-test-ubuntu-18.04-r-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1195264150
>it looks like a 🐛 in force_tests() to me
Yeah that looks like it was caused by search & replace ... 🙈 ups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929963541
##########
r/tests/testthat/helper-skip.R:
##########
@@ -70,6 +70,10 @@ skip_if_not_dev_mode <- function() {
}
skip_if_not_running_large_memory_tests <- function() {
+ if (force_tests()) {
Review Comment:
I tested `force_tests()` locally and it now works. Given the fact that we can't reproduce the OOM failure reliably, I think the best path for this PR is:
* add an `expect_true(false)` test in a commit and show that it causes a CI failure, and then
* undo the ☝🏻 commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
rok commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1191593100
@dragosmg fully agreed about the review. I can merge if they approve.
It might be that TZ was set there to expand our test set (beyond just UTC) so it might not be entirely great to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
dragosmg commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1191796598
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
jonkeane commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929943914
##########
.github/workflows/r.yml:
##########
@@ -90,9 +90,13 @@ jobs:
run: |
sudo sysctl -w kernel.core_pattern="core.%e.%p"
ulimit -c unlimited
- # Setting a non-default and non-probable Marquesas French Polynesia time
- # it has both with a .45 offset and very very few people who live there.
- archery docker run -e TZ=MART -e ARROW_R_FORCE_TESTS=${{ matrix.force-tests }} ubuntu-r
+ # TZ was set to a non-default and non-probable Marquesas French Polynesia
+ # (it has both with a .45 offset and very very few people who live there)
+ # time here. The build was failing with the following warning (probably
+ # raised to error) in them:
+ # System has not been booted with systemd as init system (PID 1). Can't operate.
+ # Failed to connect to bus: Host is down
+ archery docker run -e TZ="" -e ARROW_R_FORCE_TESTS=${{ matrix.force-tests }} ubuntu-r
Review Comment:
Great 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
jonkeane commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929950020
##########
r/tests/testthat/helper-skip.R:
##########
@@ -70,6 +70,10 @@ skip_if_not_dev_mode <- function() {
}
skip_if_not_running_large_memory_tests <- function() {
+ if (force_tests()) {
Review Comment:
For testing that `force_tests()` does actually force all the tests, we might put in an explicitly bad test (I usually do `expect_true(false)` or the like). IIUC, the OOM here isn't 100% deterministic so relying on that to be the thing that fails might be a bit frustrating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
jonkeane commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1195463957
> it looks like a 🐛 in force_tests() to me
Jakob already responded, but yeah, definitely looks like an overzealous `gsub` Thanks for catching that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1195962551
I don't have an opinion on the large memory tests, I was mostly concerned with fixing the CI. Any thoughts? @nealrichardson @jonkeane @assignUser?
Do I rename the PR and the issue (and make this a bug fix only)? or do we still want to disable the large memory tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
dragosmg commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1191788467
This seems to be causing several issues: [1](https://github.com/dragosmg/arrow/runs/7454921432?check_suite_focus=true#step:7:4812), [2](https://github.com/dragosmg/arrow/runs/7454921432?check_suite_focus=true#step:7:4812), [3](https://github.com/dragosmg/arrow/runs/7454921432?check_suite_focus=true#step:7:26245) and I think the initial problem was spurious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
dragosmg commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r926947403
##########
.github/workflows/r.yml:
##########
@@ -92,7 +92,7 @@ jobs:
ulimit -c unlimited
# Setting a non-default and non-probable Marquesas French Polynesia time
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1191826599
:warning: Ticket **has no components in JIRA**, make sure you assign one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1195200080
Should this line:
https://github.com/apache/arrow/blob/bbf249e056315af0a18d5c0834de9adef117a25f/r/tests/testthat/helper-skip.R#L25
not be:
```r
... Sys.getenv("ARROW_R_FORCE_TESTS") ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1195957490
Hmm, so you've found and fixed a different bug, that's great. But large-memory tests are still running even though the force_tests() function was broken--see r_test.sh.
Unrelated, though, it seems that the issue has resolved itself, maybe GHA fixed something on their runners? That's good. If we don't want to actually disable large memory tests on CI, then we should rename this issue to match the actual fix. If we still think it's a good idea not to try them on CI, then we should change r_test.sh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
dragosmg commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r926947566
##########
.github/workflows/r.yml:
##########
@@ -92,7 +92,7 @@ jobs:
ulimit -c unlimited
# Setting a non-default and non-probable Marquesas French Polynesia time
# it has both with a .45 offset and very very few people who live there.
Review Comment:
Done. Updated comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1191826569
https://issues.apache.org/jira/browse/ARROW-17166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1191873953
The issue is different, it's an OOM in the large memory tests: https://github.com/apache/arrow/runs/7445803518?check_suite_focus=true#step:7:26124
We should exclude them from the force-tests job on CI, removing this: https://github.com/apache/arrow/blob/master/r/tests/testthat/helper-skip.R#L73-L75
It will probably be sporadic, oom-killer is not deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
dragosmg commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1191866935
We've been seeing [this sort](https://github.com/apache/arrow/runs/7445803518?check_suite_focus=true#step:7:26180) of problems for a couple of days. I thought they were caused by the TZ Docker env variable. I too noticed the problem seems to have solved itself now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929762698
##########
r/tests/testthat/helper-skip.R:
##########
@@ -70,6 +70,10 @@ skip_if_not_dev_mode <- function() {
}
skip_if_not_running_large_memory_tests <- function() {
+ if (force_tests()) {
Review Comment:
I added it back on purpose (to test with that line in and without the bug in `force_tests()`). With the bug in, `force_tests()` can never return `true` (AFAIU). So, technically, that line is inconsequential.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
jonkeane commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1198325759
> Do I rename the PR and the issue (and make this a bug fix only)? or do we still want to disable the large memory tests? I'd be in favour of keeping the tests in.
Yeah, I would rename the PR + issue to match and describe that what it did was fix the typo | bug that we fixed.
Agreed that if the CI is cleared up on the OOMing, leaving the tests in keeps the force-all-tests job more in spirit with what it actually does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on pull request #13680: ARROW-17166: [R] [CI] force_tests() cannot return TRUE
Posted by GitBox <gi...@apache.org>.
dragosmg commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1198347050
> > Do I rename the PR and the issue (and make this a bug fix only)? or do we still want to disable the large memory tests? I'd be in favour of keeping the tests in.
>
> Yeah, I would rename the PR + issue to match and describe that what it did was fix the typo | bug that we fixed.
>
> Agreed that if the CI is cleared up on the OOMing, leaving the tests in keeps the force-all-tests job more in spirit with what it actually does.
Thanks! Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1195816471
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1195936139
> You haven't touched `skip_if_not_running_large_memory_tests()` yet so I don't think the issue is resolved.
The chunk you suggested I delete, https://github.com/apache/arrow/blob/a5a28377e43b6435eefa5cc684d80d5fb26f387a/r/tests/testthat/helper-skip.R#L73-L75,
never worked (see the 🐛 this PR solves), which makes me believe the issue wasn't related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929665850
##########
.github/workflows/r.yml:
##########
@@ -90,9 +90,13 @@ jobs:
run: |
sudo sysctl -w kernel.core_pattern="core.%e.%p"
ulimit -c unlimited
- # Setting a non-default and non-probable Marquesas French Polynesia time
- # it has both with a .45 offset and very very few people who live there.
- archery docker run -e TZ=MART -e ARROW_R_FORCE_TESTS=${{ matrix.force-tests }} ubuntu-r
+ # TZ was set to a non-default and non-probable Marquesas French Polynesia
+ # (it has both with a .45 offset and very very few people who live there)
+ # time here. The build was failing with the following warning (probably
+ # raised to error) in them:
+ # System has not been booted with systemd as init system (PID 1). Can't operate.
+ # Failed to connect to bus: Host is down
+ archery docker run -e TZ="" -e ARROW_R_FORCE_TESTS=${{ matrix.force-tests }} ubuntu-r
Review Comment:
Not sure I follow. This bit is no longer needed as the failure has nothing to do with `TZ`. So I will undo this change.
`skip_if_not_running_large_memory_tests()` should indeed cover the OOMing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929758313
##########
r/tests/testthat/helper-skip.R:
##########
@@ -70,6 +70,10 @@ skip_if_not_dev_mode <- function() {
}
skip_if_not_running_large_memory_tests <- function() {
+ if (force_tests()) {
Review Comment:
Did you add this back in accidentally? Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929762698
##########
r/tests/testthat/helper-skip.R:
##########
@@ -70,6 +70,10 @@ skip_if_not_dev_mode <- function() {
}
skip_if_not_running_large_memory_tests <- function() {
+ if (force_tests()) {
Review Comment:
I added it back on purpose (to test without the bug in `force_tests()`). Given the bug in `force_tests()`, `force_tests()` can never return `true` (AFAIU). So, technically, that line is inconsequential.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929948913
##########
r/tests/testthat/helper-skip.R:
##########
@@ -70,6 +70,10 @@ skip_if_not_dev_mode <- function() {
}
skip_if_not_running_large_memory_tests <- function() {
+ if (force_tests()) {
Review Comment:
The downside of ☝🏻 this is that, if:
```r
if (force_tests()) {
return()
}
```
was never ran (since `force_test()` would never be `TRUE`), then the issue won't be solved by removing those lines from `skip_if_not_running_large_memory_tests()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1195938960
@nealrichardson For completeness, I implemented (in cb0a707593273c4bba229f12fd106890f7c556f8 ) the change you suggested, then undone it (in add03dc9ee952a8b4efe2328c0d1a08dd20dcd83).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
rok commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r926903885
##########
.github/workflows/r.yml:
##########
@@ -92,7 +92,7 @@ jobs:
ulimit -c unlimited
# Setting a non-default and non-probable Marquesas French Polynesia time
# it has both with a .45 offset and very very few people who live there.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
dragosmg commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1191585829
It would be good to get a review from @jonkeane (they introduced the setting of the timezone in the tz Docker environment variable) and / or @nealrichardson. 🙏🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #13680: ARROW-17166: [R] [CI] Remove ENV TZ from docker filestrying something out
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #13680:
URL: https://github.com/apache/arrow/pull/13680#issuecomment-1191864422
What's the problem this solves? The most recent R CI run on master was successful: https://github.com/apache/arrow/actions/runs/2710936031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
jonkeane commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929385256
##########
.github/workflows/r.yml:
##########
@@ -90,9 +90,13 @@ jobs:
run: |
sudo sysctl -w kernel.core_pattern="core.%e.%p"
ulimit -c unlimited
- # Setting a non-default and non-probable Marquesas French Polynesia time
- # it has both with a .45 offset and very very few people who live there.
- archery docker run -e TZ=MART -e ARROW_R_FORCE_TESTS=${{ matrix.force-tests }} ubuntu-r
+ # TZ was set to a non-default and non-probable Marquesas French Polynesia
+ # (it has both with a .45 offset and very very few people who live there)
+ # time here. The build was failing with the following warning (probably
+ # raised to error) in them:
+ # System has not been booted with systemd as init system (PID 1). Can't operate.
+ # Failed to connect to bus: Host is down
+ archery docker run -e TZ="" -e ARROW_R_FORCE_TESTS=${{ matrix.force-tests }} ubuntu-r
Review Comment:
Do we still need this bit at all? I thought the new change to `skip_if_not_running_large_memory_tests()` should cover the OOMing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a diff in pull request #13680: ARROW-17166: [R] [CI] Exclude large memory tests from the force-tests job on CI
Posted by GitBox <gi...@apache.org>.
dragosmg commented on code in PR #13680:
URL: https://github.com/apache/arrow/pull/13680#discussion_r929762698
##########
r/tests/testthat/helper-skip.R:
##########
@@ -70,6 +70,10 @@ skip_if_not_dev_mode <- function() {
}
skip_if_not_running_large_memory_tests <- function() {
+ if (force_tests()) {
Review Comment:
I added it back on purpose (to test with that line in and without the bug in `force_tests()`). With the bug in `force_tests()` can never return `true` (AFAIU). So, technically, that line is inconsequential.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane merged pull request #13680: ARROW-17166: [R] [CI] force_tests() cannot return TRUE
Posted by GitBox <gi...@apache.org>.
jonkeane merged PR #13680:
URL: https://github.com/apache/arrow/pull/13680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org