You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2018/07/24 10:49:26 UTC
Review Request 68030: Fixed a linking issue with gRPC.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68030/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
Bugs: MESOS-9055
https://issues.apache.org/jira/browse/MESOS-9055
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/grpc.hpp 28a854fb96443ea13afbd034dc6d20bfbce1fec1
Diff: https://reviews.apache.org/r/68030/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 68030: Fixed a linking issue with gRPC.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68030/#review206424
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68030]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 24, 2018, 10:49 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68030/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 10:49 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9094
> https://issues.apache.org/jira/browse/MESOS-9094
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/grpc.hpp 28a854fb96443ea13afbd034dc6d20bfbce1fec1
>
>
> Diff: https://reviews.apache.org/r/68030/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 68030: Fixed a linking issue with gRPC.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68030/#review206434
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/include/process/grpc.hpp
Lines 211 (patched)
<https://reviews.apache.org/r/68030/#comment289383>
Nit: std::chrono::...
Also let's use backticks instead of single quotes.
- Chun-Hung Hsiao
On July 24, 2018, 10:49 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68030/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 10:49 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9094
> https://issues.apache.org/jira/browse/MESOS-9094
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/grpc.hpp 28a854fb96443ea13afbd034dc6d20bfbce1fec1
>
>
> Diff: https://reviews.apache.org/r/68030/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 68030: Fixed a linking issue with gRPC.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68030/#review206440
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68030']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1979/mesos-review-68030
Relevant logs:
- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1979/mesos-review-68030/logs/libprocess-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1520): warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1689): warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2273): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2280): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2292): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2301): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
cl : Command line warning D9002: ignoring unknown option '-fPIC' [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1415): warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1520): warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(1689): warning C4244: '+=': conversion from '__int64' to 'uint32_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2273): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2280): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2292): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2301): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401): warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of data [D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj] [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default target) (7) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\3rdparty\libprocess\src\mpsc_linked_queue.hpp(181): error C2327: 'process::MpscLinkedQueue<T>::tail': is not a type name, static, or enumerator (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\benchmarks.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
d:\dcos\mesos\mesos\3rdparty\libprocess\src\mpsc_linked_queue.hpp(181): error C2065: 'tail': undeclared identifier (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\benchmarks.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
d:\dcos\mesos\mesos\3rdparty\libprocess\src\mpsc_linked_queue.hpp(181): error C2327: 'process::MpscLinkedQueue<std::string>::tail': is not a type name, static, or enumerator (compiling source file D:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\benchmarks.cpp) [D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj]
18 Warning(s)
3 Error(s)
Time Elapsed 00:02:22.09
```
- Mesos Reviewbot Windows
On July 25, 2018, 11:56 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68030/
> -----------------------------------------------------------
>
> (Updated July 25, 2018, 11:56 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9094
> https://issues.apache.org/jira/browse/MESOS-9094
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a linking issue with gRPC.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/grpc.hpp 28a854fb96443ea13afbd034dc6d20bfbce1fec1
>
>
> Diff: https://reviews.apache.org/r/68030/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 68030: Fixed a linking issue with gRPC.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68030/
-----------------------------------------------------------
(Updated July 25, 2018, 11:56 a.m.)
Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
Changes
-------
Addressed issues.
Bugs: MESOS-9094
https://issues.apache.org/jira/browse/MESOS-9094
Repository: mesos
Description (updated)
-------
Fixed a linking issue with gRPC.
Diffs (updated)
-----
3rdparty/libprocess/include/process/grpc.hpp 28a854fb96443ea13afbd034dc6d20bfbce1fec1
Diff: https://reviews.apache.org/r/68030/diff/2/
Changes: https://reviews.apache.org/r/68030/diff/1-2/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 68030: Fixed a linking issue with gRPC.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68030/#review206385
-----------------------------------------------------------
PASS: Mesos patch 68030 was successfully built and tested.
Reviews applied: `['68030']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1972/mesos-review-68030
- Mesos Reviewbot Windows
On July 24, 2018, 10:49 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68030/
> -----------------------------------------------------------
>
> (Updated July 24, 2018, 10:49 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9094
> https://issues.apache.org/jira/browse/MESOS-9094
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/grpc.hpp 28a854fb96443ea13afbd034dc6d20bfbce1fec1
>
>
> Diff: https://reviews.apache.org/r/68030/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>