You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/09/19 05:19:56 UTC

[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on a change in pull request #55: [YUNIKORN-853] Update the value type of node attribute to support Any type

yangwwei commented on a change in pull request #55:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/55#discussion_r711685525



##########
File path: scheduler-interface-spec.md
##########
@@ -640,6 +641,7 @@ const (
 	ARCH                = "si/arch"
 	HostName            = "si/hostname"
 	RackName            = "si/rackname"
+       LabelName           = "si/labelname"

Review comment:
       this is the key name of the attribute, to be more self-explanatory, would it be better to rename this as `si/nodelabels`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org