[GitHub] [lucene] rmuir commented on a diff in pull request #11937: reland: 11925 javac options

[GitBox <gi...@apache.org>]

rmuir commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r1023903448


##########
gradle/hacks/turbocharge-jvm-opts.gradle:
##########
@@ -38,4 +39,20 @@ allprojects {
 
         jvmArgs += vmOpts
     }
-}
\ No newline at end of file
+
+    // Tweak javac to not be too resource-hungry.
+    // This applies to any JVM when javac runs forked (e.g. error-prone)
+    // Avoiding the fork entirely is best.
+    tasks.withType(JavaCompile) { JavaCompile task ->
+        if (task.path == ":lucene:core:compileMain19Java") {

Review Comment:
   > @rmuir altJvm is possible on 10.x as well, just pass a path to JDK17 via -Pruntime.java.home=/my/jdk/17 and it'll use that JVM.
   
   yes, i know, but i was trying to test the grid of `altjvm=True/False X errorprone=True/False` on 10.x, you can't do altjvm=True + errorprone=True, it gets disabled due to some workaround. So I tested that on 9.x
   
   thanks for looking at it, as long as jenkins is happy we are good.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org