You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/05 16:49:11 UTC

[GitHub] [geode] mhansonp commented on pull request #6924: GEODE-9645: Don't notify servers of new DataSerializers

mhansonp commented on pull request #6924:
URL: https://github.com/apache/geode/pull/6924#issuecomment-934583378


   > This seems like a potential departure from what the user might expect the behaviour to be. What are the implications of this change in terms of what the user sees happen when they register a DataSerializer? Also, there is no test coverage added as part of this PR, so it should probably be moved to draft mode until it's in a finished state.
   
   The behavior is correct. It was approved as there is no good solution when using multi-user auth. With regards to the testing, the JUnit testing I had proved to impact other seemingly unrelated tests. So I pulled them. The space where this code needs to work is full of global singletons.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org