You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/25 18:18:43 UTC

[GitHub] [airflow] vincbeck commented on a diff in pull request #23918: Fix the xfail test for batch

vincbeck commented on code in PR #23918:
URL: https://github.com/apache/airflow/pull/23918#discussion_r881977031


##########
tests/providers/amazon/aws/hooks/test_batch_waiters.py:
##########
@@ -274,19 +273,17 @@ def test_batch_job_waiting(aws_clients, aws_region, job_queue_name, job_definiti
     # moto transitions the Batch job status automatically.
 
     job_name = "test-job"
-    job_cmd = ['/bin/sh -c "for a in `seq 1 2`; do echo Hello World; sleep 0.25; done"']

Review Comment:
   I removed this optional parameter for multiple reasons:
   
   - It does not add any value to the test
   - For some reasons, the command failed to run when I run pytest



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org