You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/01/30 04:45:02 UTC
[GitHub] [parquet-mr] dongjoon-hyun opened a new pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-2
dongjoon-hyun opened a new pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky merged pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-771151698
Thank you for reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-771467534
@dongjoon-hyun, you don't need to rebase, I've already re-triggered the build. I don't know what's happening with Travis but there are unrelated failures and stuck builds in the system for several PRs. I hope, it'll be solved soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-773895800
Thanks you for the contribution, @dongjoon-hyun! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-771469863
Got it. Thank you, @gszadovszky !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky edited a comment on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
gszadovszky edited a comment on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-773895800
Thank you for the contribution, @dongjoon-hyun! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky edited a comment on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
gszadovszky edited a comment on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-773895800
Thank you for the contribution, @dongjoon-hyun! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-773493050
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-773514753
Thank you so much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-773895800
Thanks you for the contribution, @dongjoon-hyun! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky closed pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
gszadovszky closed pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-772337355
Close/re-open this PR to trigger the newly configured github action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-771263507
Do I need to rebase this PR to see the green build?
> Let's wait for a green build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-2
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-771263507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-771467534
@dongjoon-hyun, you don't need to rebase, I've already re-triggered the build. I don't know what's happening with Travis but there are unrelated failures and stuck builds in the system for several PRs. I hope, it'll be solved soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky merged pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] dongjoon-hyun commented on pull request #859: PARQUET-1967: Upgrade Zstd-jni to 1.4.8-3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #859:
URL: https://github.com/apache/parquet-mr/pull/859#issuecomment-773493050
Thank you for retriggering, @gszadovszky !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org