You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/18 08:30:00 UTC

[GitHub] [airflow] uranusjr opened a new pull request, #23053: Test case for TaskMap only check "relevant" dependencies

uranusjr opened a new pull request, #23053:
URL: https://github.com/apache/airflow/pull/23053

   When looking for "mapped dependants" of a task, we only want a task if it not only is a direct downstream of the task, but also it actually "uses" the task's pushed XCom for task mapping. So we need to peek into the mapped downstream task's expansion kwargs, and only count it as a mapped dependant if the upstream is referenced there.
   
   Fix #23018.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] github-actions[bot] commented on pull request #23053: Ensure TaskMap only checks "relevant" dependencies

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23053:
URL: https://github.com/apache/airflow/pull/23053#issuecomment-1102322807

   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb merged pull request #23053: Ensure TaskMap only checks "relevant" dependencies

Posted by GitBox <gi...@apache.org>.
ashb merged PR #23053:
URL: https://github.com/apache/airflow/pull/23053


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] uranusjr commented on pull request #23053: Ensure TaskMap only checks "relevant" dependencies

Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #23053:
URL: https://github.com/apache/airflow/pull/23053#issuecomment-1101510709

   Apparently this broke everything (import cycle?) but I can’t tell why…


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org