You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "cbornet (via GitHub)" <gi...@apache.org> on 2023/05/30 20:42:03 UTC
[GitHub] [pulsar-site] cbornet opened a new pull request, #595: [fix][site] Update docker image staging command
cbornet opened a new pull request, #595:
URL: https://github.com/apache/pulsar-site/pull/595
Fix #20438
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][site] Update docker image staging command [pulsar-site]
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #595:
URL: https://github.com/apache/pulsar-site/pull/595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][site] Update docker image staging command [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #595:
URL: https://github.com/apache/pulsar-site/pull/595#issuecomment-1818789875
> The instructions on the website should cover releasing maintenance branches too.
This is the reason why this PR is blocked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] mattisonchao commented on pull request #595: [fix][site] Update docker image staging command
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on PR #595:
URL: https://github.com/apache/pulsar-site/pull/595#issuecomment-1664899574
We should add this command in the docker building shell script. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][site] Update docker image staging command [pulsar-site]
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on code in PR #595:
URL: https://github.com/apache/pulsar-site/pull/595#discussion_r1403136551
##########
contribute/release-process.md:
##########
@@ -219,8 +219,14 @@ Run the following commands:
```shell
cd $PULSAR_HOME/docker
-./build.sh
-DOCKER_USER=<your-username> DOCKER_PASSWORD=<your-password> DOCKER_ORG=<your-username> ./publish.sh
+DOCKER_USER=<your-username>
+docker login $DOCKER_USER -u $DOCKER_USER -p <your-password>
+mvn install -DUBUNTU_MIRROR=http://azure.archive.ubuntu.com/ubuntu/ \
+ -DskipTests \
+ -Pmain,docker -Pdocker-push \
+ -Ddocker.platforms=linux/amd64,linux/arm64 \
+ -Ddocker.organization=$DOCKER_USER \
Review Comment:
Since the variable `DOCKER_USER` might not be the same as `docker.organization`, it is better to change `$DOCKER_USER` to `$DOCKER_ORGANIZATION` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] lhotari commented on pull request #595: [fix][site] Update docker image staging command
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #595:
URL: https://github.com/apache/pulsar-site/pull/595#issuecomment-1610957209
> How does this command apply to maintenance branch releases? Please cover that aspect too.
@cbornet please follow up on this. The instructions on the website should cover releasing maintenance branches too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Technoboy- commented on a diff in pull request #595: [fix][site] Update docker image staging command
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on code in PR #595:
URL: https://github.com/apache/pulsar-site/pull/595#discussion_r1339844341
##########
contribute/release-process.md:
##########
@@ -219,8 +219,14 @@ Run the following commands:
```shell
cd $PULSAR_HOME/docker
-./build.sh
-DOCKER_USER=<your-username> DOCKER_PASSWORD=<your-password> DOCKER_ORG=<your-username> ./publish.sh
+DOCKER_USER=<your-username>
+docker login $DOCKER_USER -u $DOCKER_USER -p <your-password>
Review Comment:
docker login `https://dockerhub.com` -u $DOCKER_USER -p <your-password>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][site] Update docker image staging command [pulsar-site]
Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie commented on PR #595:
URL: https://github.com/apache/pulsar-site/pull/595#issuecomment-1818117175
Do you have any updates on this? @cbornet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org