Re: svn commit: r1773397 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c

[Luca Toscano <to...@gmail.com>]

2017-01-31 10:53 GMT+01:00 Plüm, Rüdiger, Vodafone Group <
ruediger.pluem@vodafone.com>:

>
>
> > -----Ursprüngliche Nachricht-----
> > Von: Joe Orton [mailto:jorton@redhat.com]
> > Gesendet: Dienstag, 31. Januar 2017 10:42
> > An: dev@httpd.apache.org
> > Betreff: Re: svn commit: r1773397 - in /httpd/httpd/trunk: CHANGES
> > modules/proxy/mod_proxy.c
> >
> > On Mon, Jan 30, 2017 at 07:52:03AM -0500, Eric Covener wrote:
> > > I have a fix but not sure if the change should just be reverted. In
> > > the PR, the user changed the 2.2 config to make the ProxyPass within
> > > location and expected similar behavior.
> > >
> > > Should have probably just told them that exceptions just could not be
> > > done that way.
> > >
> > > PR config is
> > >
> > > ProxyPass /error !
> > > <Location />
> > >   ProxyPass http://foo/...
> > > </Location>
> > >
> > > It seemed useful at the time, but since stuffing the thing inside of
> > > Location is not all that more useful functionally, adding more code
> > > seems like a mistake.
> >
> > Asserting/documenting that higher-level exceptions don't apply for
> > ProxyPass within <Location> seems pretty reasonable to me.
> >
>
> +1


While reviewing https://bz.apache.org/bugzilla/show_bug.cgi?id=61225 I
tried to add some clarification with http://svn.apache.org/r1828069 (trunk
only for the moment, will wait a bit before backporting if anybody wants to
add/amend).

Luca