[GitHub] [arrow] pitrou commented on a diff in pull request #13365: MINOR: [Python] Fix FlightServerBase docstring

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #13365:
URL: https://github.com/apache/arrow/pull/13365#discussion_r894854792


##########
python/pyarrow/_flight.pyx:
##########
@@ -2577,7 +2577,7 @@ cdef class FlightServerBase(_Weakrefable):
     root_certificates : bytes optional, default None
         If enabling mutual TLS, this specifies the PEM-encoded root
         certificate used to validate client certificates.
-    middleware : list optional, default None
+    middleware : dict optional, default None
         A dictionary of :class:`ServerMiddlewareFactory` items. The
         keys are used to retrieve the middleware instance during calls
         (see :meth:`ServerCallContext.get_middleware`).

Review Comment:
   Also which type the keys should have? Strings?



##########
python/pyarrow/_flight.pyx:
##########
@@ -2577,7 +2577,7 @@ cdef class FlightServerBase(_Weakrefable):
     root_certificates : bytes optional, default None
         If enabling mutual TLS, this specifies the PEM-encoded root
         certificate used to validate client certificates.
-    middleware : list optional, default None
+    middleware : dict optional, default None
         A dictionary of :class:`ServerMiddlewareFactory` items. The
         keys are used to retrieve the middleware instance during calls
         (see :meth:`ServerCallContext.get_middleware`).

Review Comment:
   Also state which type the keys should have? Strings?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org