[GitHub] merlimat commented on a change in pull request #1219: Xzy initialize subscription config

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #1219: Xzy initialize subscription config
URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r167655939
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerConfiguration.java
 ##########
 @@ -321,4 +322,21 @@ public ConsumerConfiguration setProperties(Map<String, String> properties) {
     public Map<String, String> getProperties() {
         return properties;
     }
+    
+     /** 
+     * @param initializeSubscriptionOnLatest the initializeSubscriptionOnLatest to set
+     * Set cursor position when subscribing to the topic first time
+     * <p>
+     * Default is {@value true} which means {@link MessageId.lastest}
 
 Review comment:
   It's a bit unclear from this API where the subscription will be initialized if it's not on latest. We should make it clear that it's either "latest" or "earliest" (with latest as default). 
   
   Again, I think that an enum would be a better option here to better convey the 2 options.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services