You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/16 17:03:08 UTC

[GitHub] [airflow] uranusjr opened a new issue #19625: Deprecate template variables ts etc. and change the default log_filename_template

uranusjr opened a new issue #19625:
URL: https://github.com/apache/airflow/issues/19625


   ### Body
   
   Context: https://github.com/apache/airflow/issues/19058#issuecomment-947023469
   
   Note that changing the default `log_filename_template` have a lot of backward compatibility implications, and the solution needs to be cheap enough. Not a trivial job.
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr closed issue #19625: Deprecate template variables ts etc. and change the default log_filename_template

Posted by GitBox <gi...@apache.org>.

uranusjr closed issue #19625:
URL: https://github.com/apache/airflow/issues/19625


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #19625: Deprecate template variables ts etc. and change the default log_filename_template

Posted by GitBox <gi...@apache.org>.

uranusjr commented on issue #19625:
URL: https://github.com/apache/airflow/issues/19625#issuecomment-1047617443


   Yes I think so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #19625: Deprecate template variables ts etc. and change the default log_filename_template

Posted by GitBox <gi...@apache.org>.

uranusjr commented on issue #19625:
URL: https://github.com/apache/airflow/issues/19625#issuecomment-1047618051


   PR that actually flipped the switch: #21495


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #19625: Deprecate template variables ts etc. and change the default log_filename_template

Posted by GitBox <gi...@apache.org>.

ashb commented on issue #19625:
URL: https://github.com/apache/airflow/issues/19625#issuecomment-1039202376


   We can close this as done now can't we @uranusjr?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #19625: Deprecate template variables ts etc. and change the default log_filename_template

Posted by GitBox <gi...@apache.org>.

ashb commented on issue #19625:
URL: https://github.com/apache/airflow/issues/19625#issuecomment-977207750


   For AIP-42 we'll need to add some form of "task_mapping_id" in here too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #19625: Deprecate template variables ts etc. and change the default log_filename_template

Posted by GitBox <gi...@apache.org>.

uranusjr commented on issue #19625:
URL: https://github.com/apache/airflow/issues/19625#issuecomment-979031159


   Copying from Slack to record the thoughts:
   
   > My current best idea is to create a table tracking log template changes and create a fk on TaskInstance pointing to it. A row is inserted to the table when Airflow launches whenever the template does not match the last row in the table.
   
   The plan is to piggyback this operation on #18439, right after migrations are done.
   
   When a TaskInstance is created, a foreign key to this tracking table is populated to signify what log filename template this TI will use. `render_log_filename` will use this fk to render the filename, instead of accessing the config.
   
   Existing TaskInstance rows will not be backfilled for performance reasons. If this fk is NULL on TaskInstance, it will simply use the first row in the tracking table for rendering.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org