[jira] [Created] (LUCENE-6902) Fail fsync immediately

["Daniel Mitterdorfer (JIRA)" <ji...@apache.org>]

Daniel Mitterdorfer created LUCENE-6902:
-------------------------------------------

             Summary: Fail fsync immediately
                 Key: LUCENE-6902
                 URL: https://issues.apache.org/jira/browse/LUCENE-6902
             Project: Lucene - Core
          Issue Type: Improvement
            Reporter: Daniel Mitterdorfer
            Priority: Minor


While analysing a build issue in Elasticsearch I stumpled upon org.apache.lucene.util.IOUtils.fsync. It has a retry loop in fsync whenever an IOException occurs. However, there are lots of instances where a retry is not useful, e.g. when a channel has been closed, a ClosedChannelException is thrown and IOUtils#fsync still tries to fsync multiple times on the closed channel.

After bringing the issue to Robert's attention, he even opted for removing the retry logic entirely for fsyncing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org