You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/30 21:45:23 UTC

[GitHub] ogirardot commented on issue #4626: [AIRFLOW-3792] Fix in BigQuery hook queryParameters and useLegacySQL flags

ogirardot commented on issue #4626: [AIRFLOW-3792] Fix in BigQuery hook queryParameters and useLegacySQL flags
URL: https://github.com/apache/airflow/pull/4626#issuecomment-459121785
 
 
   This fix was applied in a production system, fixing a regression we had in upgrading from 1.9 to 1.10, and ran without any issue. It was properly tested using airflow dev env in Docker with `nosetests -v tests/contrib/hooks/test_bigquery_hook.py` and flake8 was checked on the relevant files.
   
   One unittest is added in this PR but it checks both the relevant issues mentioned.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services