[GitHub] [spark] MaxGekk commented on a change in pull request #26143: [SPARK-29494][SQL] Fix for ArrayOutofBoundsException while converting string to timestamp

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #26143: [SPARK-29494][SQL] Fix for ArrayOutofBoundsException while converting string to timestamp
URL: https://github.com/apache/spark/pull/26143#discussion_r335649138
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
 ##########
 @@ -456,6 +456,12 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers {
     }
   }
 
+  test("trailing characters while converting string to timestamp") {
+    val s = UTF8String.fromString("2019-10-31T10:59:23Z:::")
 
 Review comment:
   You described 2 cases in the PR discription `':'` and `' '`. This test checks the first one only. Could you add at least one more check for `' '`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org