[GitHub] [carbondata] kunal642 commented on a change in pull request #3995: [CARBONDATA-4043] Fix data load failure issue for columns added in legacy store

[GitBox <gi...@apache.org>]

kunal642 commented on a change in pull request #3995:
URL: https://github.com/apache/carbondata/pull/3995#discussion_r513983814



##########
File path: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
##########
@@ -424,6 +440,38 @@ public static boolean isHeaderValid(String tableName, String[] csvHeader,
     return noDicSortColMapping;
   }
 
+  /**
+   * Get the sort/no_sort column map based on schema order.
+   * This will be used in the final sort step to find the index of sort column, to compare the
+   * intermediate row data based on schema.
+   */
+  public static Map<Integer, List<Boolean>> getSortColSchemaOrderMapping(CarbonTable carbonTable) {

Review comment:
       Please add unit test for all the new methods




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org