You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/04 12:10:55 UTC
Review Request 45671: Updated checkpoint external mount info in
cleanup().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5104
https://issues.apache.org/jira/browse/MESOS-5104
Repository: mesos
Description
-------
Updated checkpoint external mount info in cleanup().
Diffs
-----
src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/45671/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45671: Added version checking for dvdcli.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/#review130254
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45671]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 23, 2016, 2:16 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45671/
> -----------------------------------------------------------
>
> (Updated April 23, 2016, 2:16 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5251
> https://issues.apache.org/jira/browse/MESOS-5251
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added version checking for dvdcli.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp c63fa02b8f13014bbcac6984a49eaa919d26b489
>
> Diff: https://reviews.apache.org/r/45671/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45671: Added version checking for dvdcli.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/#review130343
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45671]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 25, 2016, 3:17 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45671/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 3:17 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5267
> https://issues.apache.org/jira/browse/MESOS-5267
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added version checking for dvdcli.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp ef43c566a51d748cca318a7578db62ee3475656d
>
> Diff: https://reviews.apache.org/r/45671/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45671: Added version checking for dvdcli.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/
-----------------------------------------------------------
(Updated 四月 25, 2016, 3:17 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5267
https://issues.apache.org/jira/browse/MESOS-5267
Repository: mesos
Description
-------
Added version checking for dvdcli.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp ef43c566a51d748cca318a7578db62ee3475656d
Diff: https://reviews.apache.org/r/45671/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45671: Added version checking for dvdcli.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/
-----------------------------------------------------------
(Updated 四月 23, 2016, 2:16 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5251
https://issues.apache.org/jira/browse/MESOS-5251
Repository: mesos
Description
-------
Added version checking for dvdcli.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp c63fa02b8f13014bbcac6984a49eaa919d26b489
Diff: https://reviews.apache.org/r/45671/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45671: Added version checking for dvdcli.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/#review130202
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 77 - 103)
<https://reviews.apache.org/r/45671/#comment193909>
Let's put the check into DriverClient::create
- Jie Yu
On April 22, 2016, 9:09 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45671/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 9:09 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added version checking for dvdcli.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
>
> Diff: https://reviews.apache.org/r/45671/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45671: Added version checking for dvdcli.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45671/
-----------------------------------------------------------
(Updated 四月 22, 2016, 9:09 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Summary (updated)
-----------------
Added version checking for dvdcli.
Bugs: MESOS-5104
https://issues.apache.org/jira/browse/MESOS-5104
Repository: mesos
Description (updated)
-------
Added version checking for dvdcli.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 915e5ae755a55a02b7dfcda88165f27346cad955
Diff: https://reviews.apache.org/r/45671/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu