You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by tm...@apache.org on 2018/08/14 01:31:42 UTC
[4/6] impala git commit: IMPALA-7335/IMPALA-7418: Add logs to
HdfsScanNode to debug the issues
IMPALA-7335/IMPALA-7418: Add logs to HdfsScanNode to debug the issues
IMPALA-7335 and IMPALA-7418 are failing some builds on jenkins.
However, there is no deterministic method to reproduce them
locally and hence it is difficult to figure out the cause of the
failure. From the existing logs, it appears that the status
generated by HdfsScanNode::ProcessSplit() is lost. This log
would help determine the condition when the failures occur.
Change-Id: I68698c90031edc6ee8c31e9ce3d52dade9d8f6f1
Reviewed-on: http://gerrit.cloudera.org:8080/11174
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/2e5df138
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/2e5df138
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/2e5df138
Branch: refs/heads/master
Commit: 2e5df138aaf4354fd4ada69b627842c34fef2e05
Parents: 3cb7843
Author: poojanilangekar <po...@cloudera.com>
Authored: Wed Aug 8 18:00:08 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Mon Aug 13 22:24:41 2018 +0000
----------------------------------------------------------------------
be/src/exec/hdfs-scan-node.cc | 8 ++++++++
1 file changed, 8 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/2e5df138/be/src/exec/hdfs-scan-node.cc
----------------------------------------------------------------------
diff --git a/be/src/exec/hdfs-scan-node.cc b/be/src/exec/hdfs-scan-node.cc
index d4cef94..9db0383 100644
--- a/be/src/exec/hdfs-scan-node.cc
+++ b/be/src/exec/hdfs-scan-node.cc
@@ -330,6 +330,14 @@ void HdfsScanNode::ScannerThread(bool first_thread, int64_t scanner_thread_reser
if (!status.ok()) {
unique_lock<mutex> l(lock_);
+#ifndef NDEBUG
+ // TODO (IMPALA-7430): Remove the log message once the causes of IMPALA-7335 and
+ // IMPALA-7418 are determined.
+ VLOG_QUERY << "Non-ok status returned by ProcessSplit = " << status.msg().msg()
+ << " for Scan node (id=" << id()
+ << ", status_ = " << (status_.ok() ? "ok" : status_.msg().msg())
+ << ", done_ = " << (done_ ? "1" : "0") << ")";
+#endif
// If there was already an error, the main thread will do the cleanup
if (!status_.ok()) break;