You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/04/14 08:34:11 UTC

[GitHub] [zookeeper] rvaleti opened a new pull request #1685: ZOOKEEPER-4275 Slowness in sasl login or subject.doAs() causes zk client to falsely assume that the server did not respond, closes connection and goes to unnecessary retries

rvaleti opened a new pull request #1685:
URL: https://github.com/apache/zookeeper/pull/1685


   Raising the PR for master - approved for 3.5 branch already.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] rvaleti commented on pull request #1685: ZOOKEEPER-4275 Slowness in sasl login or subject.doAs() causes zk client to falsely assume that the server did not respond, closes connection and goes to unnecessary retries

Posted by GitBox <gi...@apache.org>.
rvaleti commented on pull request #1685:
URL: https://github.com/apache/zookeeper/pull/1685#issuecomment-819351190


   Hi, @symat - Raised this PR for master branch as suggested here - https://github.com/apache/zookeeper/pull/1684#pullrequestreview-635310075


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1685: ZOOKEEPER-4275 Slowness in sasl login or subject.doAs() causes zk client to falsely assume that the server did not respond, closes connection and goes to unnecessary retries

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1685:
URL: https://github.com/apache/zookeeper/pull/1685#issuecomment-819373461


   I re-triggered the CI (most probably we hit a flaky test again)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1685: ZOOKEEPER-4275 Slowness in sasl login or subject.doAs() causes zk client to falsely assume that the server did not respond, closes connection and goes to unnecessary retries

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1685:
URL: https://github.com/apache/zookeeper/pull/1685#issuecomment-819522364


   I already restarted the CI jobs 2 times... C client unit tests are failing, what is definitely not related to this PR about java client. If the java unit tests are passing (still running at the moment), then I'm going to merge this tomorrow unless someone has an objection.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1685: ZOOKEEPER-4275 Slowness in sasl login or subject.doAs() causes zk client to falsely assume that the server did not respond, closes connection and goes to unnecessary retries

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1685:
URL: https://github.com/apache/zookeeper/pull/1685#issuecomment-822211972


   I had to restart CI at least 5 times to get a stable run... is it always this unstable?
   I'm going to merge this fix now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1685: ZOOKEEPER-4275 Slowness in sasl login or subject.doAs() causes zk client to falsely assume that the server did not respond, closes connection and goes to unnecessary retries

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1685:
URL: https://github.com/apache/zookeeper/pull/1685#issuecomment-819377047


   If the CI passes, I'll merge this to master and also cherry-pick to the active branches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] asfgit closed pull request #1685: ZOOKEEPER-4275: Prevent unnecessary client connection retry caused by slow SASL login

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1685:
URL: https://github.com/apache/zookeeper/pull/1685


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org