You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/06 14:57:26 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #24153: Apply per-run log templates to log handlers

potiuk commented on code in PR #24153:
URL: https://github.com/apache/airflow/pull/24153#discussion_r890240351


##########
airflow/config_templates/airflow_local_settings.py:
##########
@@ -82,7 +82,6 @@
             'class': 'airflow.utils.log.file_task_handler.FileTaskHandler',
             'formatter': 'airflow',
             'base_log_folder': os.path.expanduser(BASE_LOG_FOLDER),
-            'filename_template': FILENAME_TEMPLATE,

Review Comment:
   Yeah. Custom logging config + backwards compatibiliyt is a dangerous combo



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org